Cleanup old .golangci test file, remove lint exlusion (#2831)

Author: iwahbe

.golangci.yml

@@ -37,7 +37,6 @@ issues:
     - path: pkg/tests
       linters:
         - lll
-        - paralleltest
     - path: pkg/pf/tests
       linters:
         - lll

pkg/tests/.golangci.yml

@@ -23,7 +23,7 @@ import (
 	"github.com/pulumi/pulumi-terraform-bridge/v3/unstable/testutil"
 )
 
-func TestAccProviderConfig(t *testing.T) {
+func TestAccProviderConfig(t *testing.T) { //nolint:paralleltest // integration.ProgramTest already is parallel
 	opts := accTestOptions(t).With(integration.ProgramTestOptions{
 		Dir: "provider-config",
 		ExtraRuntimeValidation: func(t *testing.T, stack integration.RuntimeValidationStackInfo) {

pkg/tests/acc_provider_config_test.go

@@ -32,7 +32,7 @@ import (
 	"github.com/pulumi/pulumi-terraform-bridge/v3/pkg/tfbridge/info"
 )
 
-func TestAccProviderSecrets(t *testing.T) {
+func TestAccProviderSecrets(t *testing.T) { //nolint:paralleltest // [integration.ProgramTest] already calls t.Parallel
 	opts := accTestOptions(t).With(integration.ProgramTestOptions{
 		Dir: "provider-secrets",
 
@@ -63,6 +63,8 @@ func TestAccProviderSecrets(t *testing.T) {
 // This tests exercise the bridge and Pulumi CLI together intentionally as secret handling for nested properties
 // historically had some quirks in the Pulumi CLI.
 func TestAccProviderConfigureSecrets(t *testing.T) {
+	t.Parallel()
+
 	type configSetter func(ctx context.Context, t *testing.T, stack *auto.Stack, basePath string, secret bool)
 
 	type primType struct {
@@ -423,6 +425,8 @@ func TestAccProviderConfigureSecrets(t *testing.T) {
 
 	for _, tc := range testCases {
 		t.Run(tc.name, func(t *testing.T) {
+			t.Parallel()
+
 			ctx := context.Background()
 			res := &schema.Resource{
 				Schema: map[string]*schema.Schema{

pkg/tests/acc_secrets_test.go

@@ -669,8 +669,8 @@ resources:
 			})
 
 			t.Run("update preview", func(t *testing.T) {
-				t.Parallel()
 				t.Skipf("Skipping this test as it this case is not handled by the TF plugin sdk")
+				t.Parallel()
 				// The TF plugin SDK does not handle removing an input for a computed value, even if the provider implements it.
 				// The plugin SDK always fills an empty Computed property with the value from the state.
 				// Diff in these cases always returns no diff and the old state value is used.

pkg/tests/diff_test/detailed_diff_unknown_test.go

@@ -34,6 +34,10 @@ func TestMain(m *testing.M) {
 	if err := setupIntegrationTests(); err != nil {
 		log.Fatal(err)
 	}
+	err := os.Setenv("PULUMI_DISABLE_AUTOMATIC_PLUGIN_ACQUISITION", "true")
+	if err != nil {
+		os.Exit(1)
+	}
 
 	exitCode := m.Run()
 	fmt.Fprintf(os.Stderr, "test main exited with code %d\n", exitCode)