Fix tfgen test (#3094)

There's something weird going on with mixing the MemFs and OsFs which
causes the test to fail on macos.

This PR switches the test to just use a normal OsFs for the test.

fixes #3092

Author: VenelinMartinov

pkg/tests/schema_generation_test.go

@@ -367,11 +367,16 @@ func Test_GenerateWithOverlay(t *testing.T) {
 
 	for _, tc := range testCases {
 		t.Run(tc.name, func(t *testing.T) {
-			root := afero.NewMemMapFs()
+			osFs := afero.NewOsFs()
+			tempDir := t.TempDir()
+			root := afero.NewBasePathFs(osFs, tempDir)
 
 			err := afero.WriteFile(root, tc.overlayFileName, tc.overlayFileContent, 0o600)
 			require.NoError(t, err)
 
+			err = root.MkdirAll(moduleName, 0o700)
+			require.NoError(t, err)
+
 			err = afero.WriteFile(root, filepath.Join(moduleName, tc.overlayModFileName), tc.overlayModFileContent, 0o600)
 			require.NoError(t, err)
 

pkg/tfbridge/provider.go

@@ -62,7 +62,7 @@ type providerOptions struct {
 
 type providerOption func(providerOptions) (providerOptions, error)
 
-func WithDefaultZeroSchemaVersion() providerOption { //nolint:revive
+func WithDefaultZeroSchemaVersion() providerOption {
 	return func(opts providerOptions) (providerOptions, error) {
 		opts.defaultZeroSchemaVersion = true
 		return opts, nil