lint fixes

Author: guineveresaenger

pkg/tfgen/installation_docs.go

@@ -2,9 +2,10 @@ package tfgen
 
 import (
 	"fmt"
+	"strings"
+
 	"golang.org/x/text/cases"
 	"golang.org/x/text/language"
-	"strings"
 )
 
 func plainDocsParser(docFile *DocFile, g *Generator) ([]byte, error) {
@@ -42,7 +43,8 @@ func writeFrontMatter(title string) string {
 func writeIndexFrontMatter(displayName string) string {
 	return fmt.Sprintf(delimiter+
 		"title: %[1]s\n"+
-		"meta_desc: The %[1]s provider for Pulumi can be used to provision any of the cloud resources available in %[1]s.\n"+
+		"meta_desc: The %[1]s provider for Pulumi "+
+		"can be used to provision any of the cloud resources available in %[1]s.\n"+
 		"layout: package\n"+
 		delimiter,
 		displayName)
@@ -80,9 +82,9 @@ func writeInstallationInstructions(goImportBasePath, providerName string) string
 		"## Installation\n\n"+
 			"The %[1]s provider is available as a package in all Pulumi languages:\n\n"+
 			"* JavaScript/TypeScript: [`@pulumi/%[1]s`](https://www.npmjs.com/package/@pulumi/%[1]s)\n"+
-			"* Python: [`pulumi-%[1]s`](https://pypi.org/project/pulumi-%[1]s/)\n"+ //TODO: get the Go mod version somehow :blood_sob:
+			"* Python: [`pulumi-%[1]s`](https://pypi.org/project/pulumi-%[1]s/)\n"+
 			"* Go: [`%[3]s`](https://github.com/pulumi/pulumi-%[1]s)\n"+
-			"* .NET: [`Pulumi.%[2]s`](https://www.nuget.org/packages/Pulumi.%[2]s)\n"+ //TODO: use capitalized
+			"* .NET: [`Pulumi.%[2]s`](https://www.nuget.org/packages/Pulumi.%[2]s)\n"+
 			"* Java: [`com.pulumi/%[1]s`](https://central.sonatype.com/artifact/com.pulumi/%[1]s)\n\n",
 		providerName,
 		cSharpName,

pkg/tfgen/installation_docs_test.go

@@ -1,10 +1,12 @@
 package tfgen
 
 import (
-	"github.com/stretchr/testify/require"
 	"testing"
+
+	"github.com/stretchr/testify/require"
 )
 
+//nolint:lll
 func TestPlainDocsParser(t *testing.T) {
 	t.Parallel()
 
@@ -13,7 +15,6 @@ func TestPlainDocsParser(t *testing.T) {
 		name     string
 		docFile  DocFile
 		expected []byte
-		g        *Generator
 	}
 
 	tests := []testCase{
@@ -47,13 +48,13 @@ func TestPlainDocsParser(t *testing.T) {
 	}
 }
 
+//nolint:lll
 func TestWriteInstallationInstructions(t *testing.T) {
 	t.Parallel()
 
 	type testCase struct {
 		// The name of the test case.
 		name             string
-		docFile          DocFile
 		goImportBasePath string
 		packageName      string
 		expected         string
@@ -65,9 +66,9 @@ func TestWriteInstallationInstructions(t *testing.T) {
 		expected: "## Installation\n\n" +
 			"The testcase provider is available as a package in all Pulumi languages:\n\n" +
 			"* JavaScript/TypeScript: [`@pulumi/testcase`](https://www.npmjs.com/package/@pulumi/testcase)\n" +
-			"* Python: [`pulumi-testcase`](https://pypi.org/project/pulumi-testcase/)\n" + //TODO: get the Go mod version somehow :blood_sob:
+			"* Python: [`pulumi-testcase`](https://pypi.org/project/pulumi-testcase/)\n" +
 			"* Go: [`github.com/pulumi/pulumi-testcase/sdk/v3/go/pulumi-testcase`](https://github.com/pulumi/pulumi-testcase)\n" +
-			"* .NET: [`Pulumi.Testcase`](https://www.nuget.org/packages/Pulumi.Testcase)\n" + //TODO: use capitalized
+			"* .NET: [`Pulumi.Testcase`](https://www.nuget.org/packages/Pulumi.Testcase)\n" +
 			"* Java: [`com.pulumi/testcase`](https://central.sonatype.com/artifact/com.pulumi/testcase)\n\n",
 		goImportBasePath: "github.com/pulumi/pulumi-testcase/sdk/v3/go/pulumi-testcase",
 		packageName:      "testcase",
@@ -76,7 +77,7 @@ func TestWriteInstallationInstructions(t *testing.T) {
 	t.Run(tc.name, func(t *testing.T) {
 		t.Parallel()
 		actual := writeInstallationInstructions(tc.goImportBasePath, tc.packageName)
-		require.Equal(t, string(tc.expected), actual)
+		require.Equal(t, tc.expected, actual)
 	})
 }
 
@@ -86,7 +87,6 @@ func TestWriteFrontMatter(t *testing.T) {
 	type testCase struct {
 		// The name of the test case.
 		name     string
-		docFile  DocFile
 		title    string
 		expected string
 	}
@@ -115,7 +115,6 @@ func TestWriteIndexFrontMatter(t *testing.T) {
 	type testCase struct {
 		// The name of the test case.
 		name        string
-		docFile     DocFile
 		displayName string
 		expected    string
 	}
@@ -125,7 +124,8 @@ func TestWriteIndexFrontMatter(t *testing.T) {
 		displayName: "Testcase",
 		expected: delimiter +
 			"title: Testcase\n" +
-			"meta_desc: The Testcase provider for Pulumi can be used to provision any of the cloud resources available in Testcase.\n" +
+			"meta_desc: The Testcase provider for Pulumi " +
+			"can be used to provision any of the cloud resources available in Testcase.\n" +
 			"layout: package\n" +
 			delimiter,
 	}