Skip to content

Commit 4e35e56

Browse files
authored
Remove some modules (#2473)
This removes three unnecessary modules: * pf/go.mod * x/muxer/go.mod * testing/go.mod And three unnecessary test modules: * pf/tests/go.mod * pkg/tests/go.mod * x/muxer/tests/go.mod This is intended to be merged with #2477 and #2480, which combine to make this a no-op for existing consumers. Refs #1445.
1 parent 678d0fd commit 4e35e56

File tree

117 files changed

+326
-11341
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

117 files changed

+326
-11341
lines changed

.golangci.yml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,11 @@ issues:
2929
- pkg/tf2pulumi/internal/config
3030
- pkg/tf2pulumi/internal/configs
3131
- pkg/vendored
32+
# TODO(https://github.com/pulumi/pulumi-terraform-bridge/issues/2474)
33+
- pf/tests
34+
- pkg/tests
35+
- testing
36+
- x/muxer/tests
3237
linters-settings:
3338
gci:
3439
sections:

Makefile

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -33,12 +33,6 @@ test:: install_plugins
3333
go build -o bin ./internal/testing/pulumi-terraform-bridge-test-provider
3434
PULUMI_TERRAFORM_BRIDGE_TEST_PROVIDER=$(shell pwd)/bin/pulumi-terraform-bridge-test-provider \
3535
go test -v -count=1 -coverprofile="coverage.txt" -coverpkg=./... -timeout 2h -parallel ${TESTPARALLELISM} ./...
36-
cd testing && go test -v -count=1 -coverprofile="coverage.txt" -coverpkg=./... ./...
37-
cd pkg/tests && go test -v -count=1 -coverprofile="coverage.txt" -coverpkg=./... -timeout 2h -parallel ${TESTPARALLELISM} ./...
38-
39-
# Unit and integration tests for the muxer.
40-
cd x/muxer && go test -v -count=1 ./...
41-
cd x/muxer/tests && go test -v -count=1 ./...
4236

4337
# Run tests while accepting current output as expected output "golden"
4438
# tests. In case where system behavior changes intentionally this can

docs/upgrade-sdk-to-mux.md

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ Framework](https://github.com/hashicorp/terraform-plugin-sdk?tab=readme-ov-file)
1414

1515
1. Find the tfgen binary `main` that calls `tfgen.Main` from
1616
`github.com/pulumi/pulumi-terraform-bridge/v3/pkg/tfgen` and update it to call
17-
`tfgen.MainWithMuxer` from `github.com/pulumi/pulumi-terraform-bridge/pf/tfgen`.
17+
`tfgen.MainWithMuxer` from `github.com/pulumi/pulumi-terraform-bridge/v3/pf/tfgen`.
1818

1919
Note that the extra version parameter is removed from `tfgen.Main`, so this code:
2020

@@ -29,7 +29,7 @@ Framework](https://github.com/hashicorp/terraform-plugin-sdk?tab=readme-ov-file)
2929
Becomes:
3030

3131
``` go
32-
import "github.com/pulumi/pulumi-terraform-bridge/pf/tfgen"
32+
import "github.com/pulumi/pulumi-terraform-bridge/v3/pf/tfgen"
3333

3434
...
3535

@@ -39,7 +39,7 @@ Framework](https://github.com/hashicorp/terraform-plugin-sdk?tab=readme-ov-file)
3939
1. Find the provider binary `main` that calls
4040
[`"github.com/pulumi/pulumi-terraform-bridge/v3/pkg/tfbridge".Main`](https://pkg.go.dev/github.com/pulumi/pulumi-terraform-bridge/v3/pkg/tfbridge#Main)
4141
and update it to
42-
[`"github.com/pulumi/pulumi-terraform-bridge/pf/tfbridge".MainWithMuxer`](https://pkg.go.dev/github.com/pulumi/pulumi-terraform-bridge/pf/tfbridge#MainWithMuxer).
42+
[`"github.com/pulumi/pulumi-terraform-bridge/v3/pf/tfbridge".MainWithMuxer`](https://pkg.go.dev/github.com/pulumi/pulumi-terraform-bridge/v3/pf/tfbridge#MainWithMuxer).
4343

4444
Note the signature changes: version parameter is removed, and `Context` is now required, so this
4545
code:
@@ -55,7 +55,7 @@ Framework](https://github.com/hashicorp/terraform-plugin-sdk?tab=readme-ov-file)
5555
Becomes:
5656

5757
```go
58-
import "github.com/pulumi/pulumi-terraform-bridge/pf/tfbridge"
58+
import "github.com/pulumi/pulumi-terraform-bridge/v3/pf/tfbridge"
5959
6060
...
6161
@@ -67,7 +67,7 @@ Framework](https://github.com/hashicorp/terraform-plugin-sdk?tab=readme-ov-file)
6767
(typically in `provider/resources.go`), changing the embedded
6868
`"github.com/pulumi/pulumi-terraform-bridge/v3/pkg/tfbridge".ProviderInfo.P` to the
6969
result of calling
70-
[`"github.com/pulumi/pulumi-terraform-bridge/pf/tfbridge".MuxShimWithPF`](https://pkg.go.dev/github.com/pulumi/pulumi-terraform-bridge/pf/tfbridge#MuxShimWithPF).
70+
[`"github.com/pulumi/pulumi-terraform-bridge/v3/pf/tfbridge".MuxShimWithPF`](https://pkg.go.dev/github.com/pulumi/pulumi-terraform-bridge/v3/pf/tfbridge#MuxShimWithPF).
7171

7272
This function combines the original SDK based provider with the new PF based provider, so this code:
7373

@@ -106,7 +106,7 @@ Framework](https://github.com/hashicorp/terraform-plugin-sdk?tab=readme-ov-file)
106106
```go
107107
import (
108108
"github.com/pulumi/pulumi-terraform-bridge/v3/pkg/tfbridge"
109-
pfbridge "github.com/pulumi/pulumi-terraform-bridge/pf/tfbridge"
109+
pfbridge "github.com/pulumi/pulumi-terraform-bridge/v3/pf/tfbridge"
110110
shimv2 "github.com/pulumi/pulumi-terraform-bridge/v3/pkg/tfshim/sdk-v2"
111111
112112
"github.com/${PROVIDER_ORG}/terraform-provider-${PROVIDER_NAME}"

dynamic/README.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -129,14 +129,14 @@ Let's go through each package in turn.
129129
### `package main`
130130

131131
`package main` is responsible for launching a Pulumi provider and setting up the parameterize call. It does
132-
this by calling [`pf/tfbridge.Main`](https://pkg.go.dev/github.com/pulumi/pulumi-terraform-bridge/[email protected]/tfbridge#Main), passing in an empty Terraform Plugin Framework provider (from
133-
[`pf/proto.Empty()`](https://pkg.go.dev/github.com/pulumi/pulumi-terraform-bridge/[email protected]/proto#Empty)). [`pf/tfbridge.ProviderMetadata`](https://pkg.go.dev/github.com/pulumi/pulumi-terraform-bridge/[email protected]/tfbridge#ProviderMetadata) allows overriding the `Parameterize` and
132+
this by calling [`pf/tfbridge.Main`](https://pkg.go.dev/github.com/pulumi/pulumi-terraform-bridge/v3/[email protected]/tfbridge#Main), passing in an empty Terraform Plugin Framework provider (from
133+
[`pf/proto.Empty()`](https://pkg.go.dev/github.com/pulumi/pulumi-terraform-bridge/v3/[email protected]/proto#Empty)). [`pf/tfbridge.ProviderMetadata`](https://pkg.go.dev/github.com/pulumi/pulumi-terraform-bridge/v3/[email protected]/tfbridge#ProviderMetadata) allows overriding the `Parameterize` and
134134
`GetSchema` call (and we override both).
135135

136136
When `Parameterize` is called, we launch the underlying Terraform provider via
137137
`internal/shim/run.LocalProvider` or `internal/shim/run.NamedProvider` (downloading as necessary). Both
138138
functions return a [`tfprotov6.ProviderServer`](https://pkg.go.dev/github.com/hashicorp/terraform-plugin-go/tfprotov6#ProviderServer) which is used to re-initialize the running provider via
139-
[`pf/tfbridge.XParameterizeResetProvider`](https://pkg.go.dev/github.com/pulumi/pulumi-terraform-bridge/[email protected]/tfbridge#XParameterizeResetProvider).
139+
[`pf/tfbridge.XParameterizeResetProvider`](https://pkg.go.dev/github.com/pulumi/pulumi-terraform-bridge/v3/[email protected]/tfbridge#XParameterizeResetProvider).
140140

141141
When `GetSchema` is called, it generates a schema from the currently equipped provider with
142142
[`pkg/tfgen.GenerateSchemaWithOptions`](https://pkg.go.dev/github.com/pulumi/pulumi-terraform-bridge/v3/pkg/tfgen#GenerateSchemaWithOptions) and returns it. All type translation, documentation generation, etc

dynamic/go.mod

Lines changed: 10 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -10,18 +10,16 @@ replace (
1010
github.com/hashicorp/terraform-plugin-sdk/v2 => github.com/pulumi/terraform-plugin-sdk/v2 v2.0.0-20240520223432-0c0bf0d65f10
1111

1212
github.com/opentofu/opentofu/shim => ./internal/shim
13-
github.com/pulumi/pulumi-terraform-bridge/pf => ../pf
1413
github.com/pulumi/pulumi-terraform-bridge/v3 => ../
1514
)
1615

1716
require (
1817
github.com/blang/semver v3.5.1+incompatible
1918
github.com/hexops/autogold/v2 v2.2.1
2019
github.com/opentofu/opentofu/shim v0.0.0-00010101000000-000000000000
21-
github.com/pulumi/pulumi-terraform-bridge/pf v0.0.0-00010101000000-000000000000
2220
github.com/pulumi/pulumi-terraform-bridge/v3 v3.92.0
2321
github.com/stretchr/testify v1.9.0
24-
google.golang.org/protobuf v1.34.0
22+
google.golang.org/protobuf v1.34.2
2523
)
2624

2725
require (
@@ -31,8 +29,7 @@ require (
3129

3230
require (
3331
cloud.google.com/go v0.112.1 // indirect
34-
cloud.google.com/go/compute v1.25.0 // indirect
35-
cloud.google.com/go/compute/metadata v0.2.3 // indirect
32+
cloud.google.com/go/compute/metadata v0.3.0 // indirect
3633
cloud.google.com/go/iam v1.1.6 // indirect
3734
cloud.google.com/go/kms v1.15.7 // indirect
3835
cloud.google.com/go/logging v1.9.0 // indirect
@@ -112,7 +109,7 @@ require (
112109
github.com/gofrs/uuid v4.2.0+incompatible // indirect
113110
github.com/gogo/protobuf v1.3.2 // indirect
114111
github.com/golang-jwt/jwt/v5 v5.2.1 // indirect
115-
github.com/golang/glog v1.2.0 // indirect
112+
github.com/golang/glog v1.2.1 // indirect
116113
github.com/golang/groupcache v0.0.0-20210331224755-41bb18bfe9da // indirect
117114
github.com/golang/protobuf v1.5.4 // indirect
118115
github.com/google/go-cmp v0.6.0 // indirect
@@ -132,7 +129,7 @@ require (
132129
github.com/hashicorp/go-getter v1.7.5 // indirect
133130
github.com/hashicorp/go-hclog v1.6.3 // indirect
134131
github.com/hashicorp/go-multierror v1.1.1 // indirect
135-
github.com/hashicorp/go-plugin v1.6.0 // indirect
132+
github.com/hashicorp/go-plugin v1.6.1 // indirect
136133
github.com/hashicorp/go-retryablehttp v0.7.7 // indirect
137134
github.com/hashicorp/go-rootcerts v1.0.2 // indirect
138135
github.com/hashicorp/go-safetemp v1.0.0 // indirect
@@ -144,8 +141,8 @@ require (
144141
github.com/hashicorp/hcl v1.0.0 // indirect
145142
github.com/hashicorp/hcl/v2 v2.20.1 // indirect
146143
github.com/hashicorp/hil v0.0.0-20190212132231-97b3a9cdfa93 // indirect
147-
github.com/hashicorp/terraform-plugin-framework v1.7.0 // indirect
148-
github.com/hashicorp/terraform-plugin-go v0.23.0
144+
github.com/hashicorp/terraform-plugin-framework v1.12.0 // indirect
145+
github.com/hashicorp/terraform-plugin-go v0.24.0
149146
github.com/hashicorp/terraform-plugin-log v0.9.0 // indirect
150147
github.com/hashicorp/terraform-plugin-mux v0.16.0 // indirect
151148
github.com/hashicorp/terraform-registry-address v0.2.3 // indirect
@@ -204,7 +201,6 @@ require (
204201
github.com/pulumi/esc v0.10.0 // indirect
205202
github.com/pulumi/inflector v0.1.1 // indirect
206203
github.com/pulumi/pulumi-java/pkg v0.16.1 // indirect
207-
github.com/pulumi/pulumi-terraform-bridge/x/muxer v0.0.10 // indirect
208204
github.com/pulumi/pulumi-yaml v1.10.3 // indirect
209205
github.com/pulumi/pulumi/pkg/v3 v3.136.1
210206
github.com/pulumi/pulumi/sdk/v3 v3.136.1
@@ -250,7 +246,7 @@ require (
250246
golang.org/x/exp v0.0.0-20240604190554-fc45aab8b7f8 // indirect
251247
golang.org/x/mod v0.18.0 // indirect
252248
golang.org/x/net v0.27.0 // indirect
253-
golang.org/x/oauth2 v0.18.0 // indirect
249+
golang.org/x/oauth2 v0.21.0 // indirect
254250
golang.org/x/sync v0.7.0 // indirect
255251
golang.org/x/sys v0.22.0 // indirect
256252
golang.org/x/term v0.22.0 // indirect
@@ -259,11 +255,10 @@ require (
259255
golang.org/x/tools v0.22.0 // indirect
260256
golang.org/x/xerrors v0.0.0-20231012003039-104605ab7028 // indirect
261257
google.golang.org/api v0.169.0 // indirect
262-
google.golang.org/appengine v1.6.8 // indirect
263258
google.golang.org/genproto v0.0.0-20240311173647-c811ad7063a7 // indirect
264-
google.golang.org/genproto/googleapis/api v0.0.0-20240311173647-c811ad7063a7 // indirect
265-
google.golang.org/genproto/googleapis/rpc v0.0.0-20240311173647-c811ad7063a7 // indirect
266-
google.golang.org/grpc v1.63.2 // indirect
259+
google.golang.org/genproto/googleapis/api v0.0.0-20240604185151-ef581f913117 // indirect
260+
google.golang.org/genproto/googleapis/rpc v0.0.0-20240604185151-ef581f913117 // indirect
261+
google.golang.org/grpc v1.66.2 // indirect
267262
gopkg.in/warnings.v0 v0.1.2 // indirect
268263
gopkg.in/yaml.v3 v3.0.1 // indirect
269264
lukechampine.com/frand v1.4.2 // indirect

0 commit comments

Comments
 (0)