fix comptued tests

Author: VenelinMartinov

pkg/tests/diff_test/detailed_diff_primitive_test.go

@@ -8,8 +8,9 @@ import (
 	"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
 	"github.com/hexops/autogold/v2"
-	crosstests "github.com/pulumi/pulumi-terraform-bridge/v3/pkg/internal/tests/cross-tests"
 	"github.com/zclconf/go-cty/cty"
+
+	crosstests "github.com/pulumi/pulumi-terraform-bridge/v3/pkg/internal/tests/cross-tests"
 )
 
 func TestSDKv2DetailedDiffString(t *testing.T) {
@@ -54,7 +55,7 @@ func TestSDKv2DetailedDiffString(t *testing.T) {
 	}
 
 	setComputedFunc := func(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics {
-		if d.Get("string_prop") == nil {
+		if _, ok := d.GetOk("string_prop"); !ok {
 			err := d.Set("string_prop", "computed")
 			if err != nil {
 				return diag.FromErr(err)

pkg/tests/diff_test/testdata/TestSDKv2DetailedDiffString/optionalComputed/added.golden

@@ -10,7 +10,7 @@ Terraform will perform the following actions:
   # crossprovider_test_res.example will be updated in-place
   ~ resource "crossprovider_test_res" "example" {
         id          = "id"
-      + string_prop = "val1"
+      ~ string_prop = "computed" -> "val1"
     }
 
 Plan: 0 to add, 1 to change, 0 to destroy.
@@ -22,10 +22,10 @@ Plan: 0 to add, 1 to change, 0 to destroy.
     ~ crossprovider:index/testRes:TestRes: (update)
         [id=id]
         [urn=urn:pulumi:test::project::crossprovider:index/testRes:TestRes::example]
-      + stringProp: "val1"
+      ~ stringProp: "computed" => "val1"
 Resources:
     ~ 1 to update
     1 unchanged
 `,
-	detailedDiff: map[string]interface{}{"stringProp": map[string]interface{}{}},
+	detailedDiff: map[string]interface{}{"stringProp": map[string]interface{}{"kind": "UPDATE"}},
 }

pkg/tests/diff_test/testdata/TestSDKv2DetailedDiffString/optionalComputedForceNew/added.golden

@@ -10,7 +10,7 @@ Terraform will perform the following actions:
   # crossprovider_test_res.example must be replaced
 +/- resource "crossprovider_test_res" "example" {
       ~ id          = "id" -> (known after apply)
-      + string_prop = "val1" # forces replacement
+      ~ string_prop = "computed" -> "val1" # forces replacement
     }
 
 Plan: 1 to add, 0 to change, 1 to destroy.
@@ -22,10 +22,10 @@ Plan: 1 to add, 0 to change, 1 to destroy.
     +-crossprovider:index/testRes:TestRes: (replace)
         [id=id]
         [urn=urn:pulumi:test::project::crossprovider:index/testRes:TestRes::example]
-      + stringProp: "val1"
+      ~ stringProp: "computed" => "val1"
 Resources:
     +-1 to replace
     1 unchanged
 `,
-	detailedDiff: map[string]interface{}{"stringProp": map[string]interface{}{"kind": "ADD_REPLACE"}},
+	detailedDiff: map[string]interface{}{"stringProp": map[string]interface{}{"kind": "UPDATE_REPLACE"}},
 }