Improve preview for set elements with computed properties (#3025)

This PR improves the preview displayed for set elements with computed
properties in two ways:

1. Fixes hashing of set elements to more closely mimic what TF does - TF
never hashes nulls or computed values in set elements, so we adopt their
behaviour by using the plugin-sdk `MapFieldReader`.
2. By dropping unknowns when hashing elements we can now correctly match
elements from the plan to the state in cases where the resource is
replaced.

Fixes #3018
Fixes #2779

Related to pulumi/pulumi-aws#5438
Related to pulumi/pulumi-gcp#3142

Author: VenelinMartinov

pkg/tests/diff_test/testdata/TestSDKv2DetailedDiffSetComputedBlock/block_with_computed_and_nested_force_new/added_end.golden

@@ -51,10 +51,6 @@ Plan: 1 to add, 0 to change, 1 to destroy.
         [id=id]
         [urn=urn:pulumi:test::project::crossprovider:index/testRes:TestRes::example]
       ~ props: [
-          ~ [0]: {
-                }
-          ~ [1]: {
-                }
           + [2]: {
                   + nestedProp: "val3"
                 }
@@ -63,9 +59,5 @@ Resources:
     +-1 to replace
     1 unchanged
 `,
-	detailedDiff: map[string]interface{}{
-		"props[0].computed": map[string]interface{}{"kind": "UPDATE"},
-		"props[1].computed": map[string]interface{}{"kind": "UPDATE"},
-		"props[2]":          map[string]interface{}{"kind": "ADD_REPLACE"},
-	},
+	detailedDiff: map[string]interface{}{"props[2]": map[string]interface{}{"kind": "ADD_REPLACE"}},
 }

pkg/tests/diff_test/testdata/TestSDKv2DetailedDiffSetComputedBlock/block_with_computed_and_nested_force_new/added_end_unordered.golden

@@ -51,10 +51,6 @@ Plan: 1 to add, 0 to change, 1 to destroy.
         [id=id]
         [urn=urn:pulumi:test::project::crossprovider:index/testRes:TestRes::example]
       ~ props: [
-          ~ [0]: {
-                }
-          ~ [1]: {
-                }
           + [2]: {
                   + nestedProp: "val1"
                 }
@@ -63,9 +59,5 @@ Resources:
     +-1 to replace
     1 unchanged
 `,
-	detailedDiff: map[string]interface{}{
-		"props[0].computed": map[string]interface{}{"kind": "UPDATE"},
-		"props[1].computed": map[string]interface{}{"kind": "UPDATE"},
-		"props[2]":          map[string]interface{}{"kind": "ADD_REPLACE"},
-	},
+	detailedDiff: map[string]interface{}{"props[2]": map[string]interface{}{"kind": "ADD_REPLACE"}},
 }

pkg/tests/diff_test/testdata/TestSDKv2DetailedDiffSetComputedBlock/block_with_computed_and_nested_force_new/added_front.golden

@@ -51,25 +51,13 @@ Plan: 1 to add, 0 to change, 1 to destroy.
         [id=id]
         [urn=urn:pulumi:test::project::crossprovider:index/testRes:TestRes::example]
       ~ props: [
-          ~ [0]: {
-                  ~ nestedProp: "val2" => "val1"
-                }
-          ~ [1]: {
-                  ~ nestedProp: "val3" => "val2"
-                }
-          + [2]: {
-                  + nestedProp: "val3"
+          + [0]: {
+                  + nestedProp: "val1"
                 }
         ]
 Resources:
     +-1 to replace
     1 unchanged
 `,
-	detailedDiff: map[string]interface{}{
-		"props[0].computed":   map[string]interface{}{"kind": "UPDATE"},
-		"props[0].nestedProp": map[string]interface{}{"kind": "UPDATE_REPLACE"},
-		"props[1].computed":   map[string]interface{}{"kind": "UPDATE"},
-		"props[1].nestedProp": map[string]interface{}{"kind": "UPDATE_REPLACE"},
-		"props[2]":            map[string]interface{}{"kind": "ADD_REPLACE"},
-	},
+	detailedDiff: map[string]interface{}{"props[0]": map[string]interface{}{"kind": "ADD_REPLACE"}},
 }

pkg/tests/diff_test/testdata/TestSDKv2DetailedDiffSetComputedBlock/block_with_computed_and_nested_force_new/added_front_unordered.golden

@@ -51,23 +51,13 @@ Plan: 1 to add, 0 to change, 1 to destroy.
         [id=id]
         [urn=urn:pulumi:test::project::crossprovider:index/testRes:TestRes::example]
       ~ props: [
-          ~ [0]: {
-                  ~ nestedProp: "val1" => "val2"
-                }
-          ~ [1]: {
-                }
-          + [2]: {
-                  + nestedProp: "val1"
+          + [0]: {
+                  + nestedProp: "val2"
                 }
         ]
 Resources:
     +-1 to replace
     1 unchanged
 `,
-	detailedDiff: map[string]interface{}{
-		"props[0].computed":   map[string]interface{}{"kind": "UPDATE"},
-		"props[0].nestedProp": map[string]interface{}{"kind": "UPDATE_REPLACE"},
-		"props[1].computed":   map[string]interface{}{"kind": "UPDATE"},
-		"props[2]":            map[string]interface{}{"kind": "ADD_REPLACE"},
-	},
+	detailedDiff: map[string]interface{}{"props[0]": map[string]interface{}{"kind": "ADD_REPLACE"}},
 }

pkg/tests/diff_test/testdata/TestSDKv2DetailedDiffSetComputedBlock/block_with_computed_and_nested_force_new/added_middle.golden

@@ -51,23 +51,13 @@ Plan: 1 to add, 0 to change, 1 to destroy.
         [id=id]
         [urn=urn:pulumi:test::project::crossprovider:index/testRes:TestRes::example]
       ~ props: [
-          ~ [0]: {
-                }
-          ~ [1]: {
-                  ~ nestedProp: "val3" => "val2"
-                }
-          + [2]: {
-                  + nestedProp: "val3"
+          + [1]: {
+                  + nestedProp: "val2"
                 }
         ]
 Resources:
     +-1 to replace
     1 unchanged
 `,
-	detailedDiff: map[string]interface{}{
-		"props[0].computed":   map[string]interface{}{"kind": "UPDATE"},
-		"props[1].computed":   map[string]interface{}{"kind": "UPDATE"},
-		"props[1].nestedProp": map[string]interface{}{"kind": "UPDATE_REPLACE"},
-		"props[2]":            map[string]interface{}{"kind": "ADD_REPLACE"},
-	},
+	detailedDiff: map[string]interface{}{"props[1]": map[string]interface{}{"kind": "ADD_REPLACE"}},
 }

pkg/tests/diff_test/testdata/TestSDKv2DetailedDiffSetComputedBlock/block_with_computed_and_nested_force_new/added_middle_unordered.golden

@@ -51,25 +51,13 @@ Plan: 1 to add, 0 to change, 1 to destroy.
         [id=id]
         [urn=urn:pulumi:test::project::crossprovider:index/testRes:TestRes::example]
       ~ props: [
-          ~ [0]: {
-                  ~ nestedProp: "val1" => "val2"
-                }
-          ~ [1]: {
-                  ~ nestedProp: "val2" => "val3"
-                }
-          + [2]: {
-                  + nestedProp: "val1"
+          + [1]: {
+                  + nestedProp: "val3"
                 }
         ]
 Resources:
     +-1 to replace
     1 unchanged
 `,
-	detailedDiff: map[string]interface{}{
-		"props[0].computed":   map[string]interface{}{"kind": "UPDATE"},
-		"props[0].nestedProp": map[string]interface{}{"kind": "UPDATE_REPLACE"},
-		"props[1].computed":   map[string]interface{}{"kind": "UPDATE"},
-		"props[1].nestedProp": map[string]interface{}{"kind": "UPDATE_REPLACE"},
-		"props[2]":            map[string]interface{}{"kind": "ADD_REPLACE"},
-	},
+	detailedDiff: map[string]interface{}{"props[1]": map[string]interface{}{"kind": "ADD_REPLACE"}},
 }

pkg/tests/diff_test/testdata/TestSDKv2DetailedDiffSetComputedBlock/block_with_computed_and_nested_force_new/removed_end.golden

@@ -51,10 +51,6 @@ Plan: 1 to add, 0 to change, 1 to destroy.
         [id=id]
         [urn=urn:pulumi:test::project::crossprovider:index/testRes:TestRes::example]
       ~ props: [
-          ~ [0]: {
-                }
-          ~ [1]: {
-                }
           - [2]: {
                   - computed  : ""
                   - nestedProp: "val3"
@@ -64,9 +60,5 @@ Resources:
     +-1 to replace
     1 unchanged
 `,
-	detailedDiff: map[string]interface{}{
-		"props[0].computed": map[string]interface{}{"kind": "UPDATE"},
-		"props[1].computed": map[string]interface{}{"kind": "UPDATE"},
-		"props[2]":          map[string]interface{}{"kind": "DELETE_REPLACE"},
-	},
+	detailedDiff: map[string]interface{}{"props[2]": map[string]interface{}{"kind": "DELETE_REPLACE"}},
 }

pkg/tests/diff_test/testdata/TestSDKv2DetailedDiffSetComputedBlock/block_with_computed_and_nested_force_new/removed_end_unordered.golden

@@ -51,26 +51,14 @@ Plan: 1 to add, 0 to change, 1 to destroy.
         [id=id]
         [urn=urn:pulumi:test::project::crossprovider:index/testRes:TestRes::example]
       ~ props: [
-          ~ [0]: {
-                  ~ nestedProp: "val1" => "val2"
-                }
-          ~ [1]: {
-                  ~ nestedProp: "val2" => "val3"
-                }
-          - [2]: {
+          - [0]: {
                   - computed  : ""
-                  - nestedProp: "val3"
+                  - nestedProp: "val1"
                 }
         ]
 Resources:
     +-1 to replace
     1 unchanged
 `,
-	detailedDiff: map[string]interface{}{
-		"props[0].computed":   map[string]interface{}{"kind": "UPDATE"},
-		"props[0].nestedProp": map[string]interface{}{"kind": "UPDATE_REPLACE"},
-		"props[1].computed":   map[string]interface{}{"kind": "UPDATE"},
-		"props[1].nestedProp": map[string]interface{}{"kind": "UPDATE_REPLACE"},
-		"props[2]":            map[string]interface{}{"kind": "DELETE_REPLACE"},
-	},
+	detailedDiff: map[string]interface{}{"props[0]": map[string]interface{}{"kind": "DELETE_REPLACE"}},
 }

pkg/tests/diff_test/testdata/TestSDKv2DetailedDiffSetComputedBlock/block_with_computed_and_nested_force_new/removed_front.golden

@@ -51,26 +51,14 @@ Plan: 1 to add, 0 to change, 1 to destroy.
         [id=id]
         [urn=urn:pulumi:test::project::crossprovider:index/testRes:TestRes::example]
       ~ props: [
-          ~ [0]: {
-                  ~ nestedProp: "val1" => "val2"
-                }
-          ~ [1]: {
-                  ~ nestedProp: "val2" => "val3"
-                }
-          - [2]: {
+          - [0]: {
                   - computed  : ""
-                  - nestedProp: "val3"
+                  - nestedProp: "val1"
                 }
         ]
 Resources:
     +-1 to replace
     1 unchanged
 `,
-	detailedDiff: map[string]interface{}{
-		"props[0].computed":   map[string]interface{}{"kind": "UPDATE"},
-		"props[0].nestedProp": map[string]interface{}{"kind": "UPDATE_REPLACE"},
-		"props[1].computed":   map[string]interface{}{"kind": "UPDATE"},
-		"props[1].nestedProp": map[string]interface{}{"kind": "UPDATE_REPLACE"},
-		"props[2]":            map[string]interface{}{"kind": "DELETE_REPLACE"},
-	},
+	detailedDiff: map[string]interface{}{"props[0]": map[string]interface{}{"kind": "DELETE_REPLACE"}},
 }

pkg/tests/diff_test/testdata/TestSDKv2DetailedDiffSetComputedBlock/block_with_computed_and_nested_force_new/removed_front_unordered.golden

@@ -51,26 +51,14 @@ Plan: 1 to add, 0 to change, 1 to destroy.
         [id=id]
         [urn=urn:pulumi:test::project::crossprovider:index/testRes:TestRes::example]
       ~ props: [
-          ~ [0]: {
-                  ~ nestedProp: "val1" => "val3"
-                }
-          ~ [1]: {
-                  ~ nestedProp: "val2" => "val1"
-                }
-          - [2]: {
+          - [1]: {
                   - computed  : ""
-                  - nestedProp: "val3"
+                  - nestedProp: "val2"
                 }
         ]
 Resources:
     +-1 to replace
     1 unchanged
 `,
-	detailedDiff: map[string]interface{}{
-		"props[0].computed":   map[string]interface{}{"kind": "UPDATE"},
-		"props[0].nestedProp": map[string]interface{}{"kind": "UPDATE_REPLACE"},
-		"props[1].computed":   map[string]interface{}{"kind": "UPDATE"},
-		"props[1].nestedProp": map[string]interface{}{"kind": "UPDATE_REPLACE"},
-		"props[2]":            map[string]interface{}{"kind": "DELETE_REPLACE"},
-	},
+	detailedDiff: map[string]interface{}{"props[1]": map[string]interface{}{"kind": "DELETE_REPLACE"}},
 }