Migrate cross-tests from input_cross_test.go to tests/provider_test.go (#2510)

This PR migrates our tests away from input_cross_tests.go to the public
`crosstests.Create`, removing `runCreateInputCheck` in the process. The
only tests removed were tests of `runCreateInputCheck` itself.

Author: iwahbe

pkg/internal/tests/cross-tests/assert.go

@@ -3,6 +3,7 @@ package crosstests
 import (
 	"github.com/hashicorp/go-cty/cty"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
+	"github.com/stretchr/testify/assert"
 	"github.com/stretchr/testify/require"
 )
 
@@ -30,7 +31,7 @@ func assertValEqual(t T, name string, tfVal, pulVal any) {
 	}
 }
 
-func assertResourceDataEqual(t T, schema map[string]*schema.Schema, tfResult, puResult *schema.ResourceData) {
+func assertResourceDataEqual(t T, resourceSchema map[string]*schema.Schema, tfResult, puResult *schema.ResourceData) {
 	// We are unable to assert that both providers were configured with the exact same
 	// data. Type information doesn't line up in the simple case. This just doesn't work:
 	//
@@ -41,7 +42,17 @@ func assertResourceDataEqual(t T, schema map[string]*schema.Schema, tfResult, pu
 	assertCtyValEqual(t, "RawPlan", tfResult.GetRawPlan(), puResult.GetRawPlan())
 	assertCtyValEqual(t, "RawState", tfResult.GetRawState(), puResult.GetRawState())
 
-	for k := range schema {
+	for _, timeout := range []string{
+		schema.TimeoutCreate,
+		schema.TimeoutRead,
+		schema.TimeoutUpdate,
+		schema.TimeoutDelete,
+		schema.TimeoutDefault,
+	} {
+		assert.Equal(t, tfResult.Timeout(timeout), puResult.Timeout(timeout), "timeout %s", timeout)
+	}
+
+	for k := range resourceSchema {
 		// TODO: make this recursive
 		tfVal := tfResult.Get(k)
 		pulVal := puResult.Get(k)

pkg/internal/tests/cross-tests/configure.go

@@ -35,7 +35,10 @@ func MakeConfigure(
 	provider map[string]*schema.Schema, tfConfig cty.Value, puConfig resource.PropertyMap,
 	options ...ConfigureOption,
 ) func(*testing.T) {
-	return func(t *testing.T) { Configure(t, provider, tfConfig, puConfig, options...) }
+	return func(t *testing.T) {
+		t.Parallel()
+		Configure(t, provider, tfConfig, puConfig, options...)
+	}
 }
 
 // Configure validates that a Terraform provider witnesses the same input when:

pkg/internal/tests/cross-tests/create.go

@@ -15,6 +15,7 @@ package crosstests
 
 import (
 	"context"
+	"testing"
 
 	"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
@@ -29,6 +30,17 @@ import (
 	shimv2 "github.com/pulumi/pulumi-terraform-bridge/v3/pkg/tfshim/sdk-v2"
 )
 
+// MakeCreate is a helper function for calling [Create] in [testing.T.Run] subcases.
+func MakeCreate(
+	resource map[string]*schema.Schema, tfConfig cty.Value, puConfig resource.PropertyMap,
+	options ...CreateOption,
+) func(t *testing.T) {
+	return func(t *testing.T) {
+		t.Parallel()
+		Create(t, resource, tfConfig, puConfig, options...)
+	}
+}
+
 // Create validates that a Terraform provider witnesses the same input when:
 // - invoked directly with HCL on tfConfig
 // - bridged and invoked via Pulumi YAML on puConfig