Skip to content

Commit 7dd77ef

Browse files
Re-record forceNew collection interactions with unknowns under detailed diff v2 (#2516)
This re-records the tests in #2515 under detailed diff v2 to show the changes. The new behaviour is more correct: When the parent of a known property with ForceNew is changed to unknown we now mark the resource for replacement. Both are guesses to the actual effect of the changes but this one seems more likely. stacked on https://github.com/pulumi/pulumi-terraform-bridge/pull/2515\ related to #2496 (comment)
1 parent 5b96472 commit 7dd77ef

File tree

1 file changed

+10
-9
lines changed

1 file changed

+10
-9
lines changed

pkg/tests/schema_pulumi_test.go

Lines changed: 10 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4163,7 +4163,8 @@ func TestMakeTerraformResultNilVsEmptyMap(t *testing.T) {
41634163

41644164
func TestUnknownCollectionForceNewDetailedDiff(t *testing.T) {
41654165
// TODO: Remove this once accurate bridge previews are rolled out
4166-
t.Setenv("PULUMI_TF_BRIDGE_ACCURATE_BRIDGE_PREVIEW", "false")
4166+
t.Setenv("PULUMI_TF_BRIDGE_ACCURATE_BRIDGE_PREVIEW", "true")
4167+
41674168
collectionForceNewResource := func(typ schema.ValueType) *schema.Resource {
41684169
return &schema.Resource{
41694170
Schema: map[string]*schema.Schema{
@@ -4383,7 +4384,7 @@ Resources:
43834384
[urn=urn:pulumi:test::test::pulumi:pulumi:Stack::test-test]
43844385
+ prov:index/aux:Aux: (create)
43854386
[urn=urn:pulumi:test::test::prov:index/aux:Aux::auxRes]
4386-
~ prov:index/test:Test: (update)
4387+
+-prov:index/test:Test: (replace)
43874388
[id=newid]
43884389
[urn=urn:pulumi:test::test::prov:index/test:Test::mainRes]
43894390
~ tests: [
@@ -4394,7 +4395,7 @@ Resources:
43944395
]
43954396
Resources:
43964397
+ 1 to create
4397-
~ 1 to update
4398+
+-1 to replace
43984399
2 changes. 1 unchanged
43994400
`))
44004401
})
@@ -4406,7 +4407,7 @@ Resources:
44064407
[urn=urn:pulumi:test::test::pulumi:pulumi:Stack::test-test]
44074408
+ prov:index/aux:Aux: (create)
44084409
[urn=urn:pulumi:test::test::prov:index/aux:Aux::auxRes]
4409-
~ prov:index/test:Test: (update)
4410+
+-prov:index/test:Test: (replace)
44104411
[id=newid]
44114412
[urn=urn:pulumi:test::test::prov:index/test:Test::mainRes]
44124413
- tests: [
@@ -4417,7 +4418,7 @@ Resources:
44174418
+ tests: output<string>
44184419
Resources:
44194420
+ 1 to create
4420-
~ 1 to update
4421+
+-1 to replace
44214422
2 changes. 1 unchanged
44224423
`))
44234424
})
@@ -4545,7 +4546,7 @@ Resources:
45454546
[urn=urn:pulumi:test::test::pulumi:pulumi:Stack::test-test]
45464547
+ prov:index/aux:Aux: (create)
45474548
[urn=urn:pulumi:test::test::prov:index/aux:Aux::auxRes]
4548-
~ prov:index/test:Test: (update)
4549+
+-prov:index/test:Test: (replace)
45494550
[id=newid]
45504551
[urn=urn:pulumi:test::test::prov:index/test:Test::mainRes]
45514552
~ tests: [
@@ -4556,7 +4557,7 @@ Resources:
45564557
]
45574558
Resources:
45584559
+ 1 to create
4559-
~ 1 to update
4560+
+-1 to replace
45604561
2 changes. 1 unchanged
45614562
`))
45624563
})
@@ -4568,7 +4569,7 @@ Resources:
45684569
[urn=urn:pulumi:test::test::pulumi:pulumi:Stack::test-test]
45694570
+ prov:index/aux:Aux: (create)
45704571
[urn=urn:pulumi:test::test::prov:index/aux:Aux::auxRes]
4571-
~ prov:index/test:Test: (update)
4572+
+-prov:index/test:Test: (replace)
45724573
[id=newid]
45734574
[urn=urn:pulumi:test::test::prov:index/test:Test::mainRes]
45744575
- tests: [
@@ -4579,7 +4580,7 @@ Resources:
45794580
+ tests: output<string>
45804581
Resources:
45814582
+ 1 to create
4582-
~ 1 to update
4583+
+-1 to replace
45834584
2 changes. 1 unchanged
45844585
`))
45854586
})

0 commit comments

Comments
 (0)