fix: edit rule paths (#2422)

guineveresaenger · web-flow · commit cfb0bd94df7e · 2024-09-18T09:25:24.000-07:00
Installation docs were calling edit rules without filtering for valid
paths first. This PR fixes that.
diff --git a/pkg/tfgen/installation_docs.go b/pkg/tfgen/installation_docs.go
@@ -131,12 +131,9 @@ func applyEditRules(contentBytes []byte, docFile string, g *Generator) ([]byte,
 		reReplace(`block contains the following arguments`,
 			`input has the following nested fields`),
 	)
-	var err error
-	for _, rule := range edits {
-		contentBytes, err = rule.Edit(docFile, contentBytes)
-		if err != nil {
-			return nil, err
-		}
+	contentBytes, err := edits.apply(docFile, contentBytes)
+	if err != nil {
+		return nil, err
 	}
 	return contentBytes, nil
 }

Original file line number	Diff line number	Diff line change
`@@ -131,12 +131,9 @@ func applyEditRules(contentBytes []byte, docFile string, g *Generator) ([]byte,`
`131`	`131`	reReplace(`block contains the following arguments`,
`132`	`132`	`input has the following nested fields`),
`133`	`133`	`)`
`134`		`- var err error`
`135`		`- for _, rule := range edits {`
`136`		`- contentBytes, err = rule.Edit(docFile, contentBytes)`
`137`		`- if err != nil {`
`138`		`- return nil, err`
`139`		`- }`
	`134`	`+ contentBytes, err := edits.apply(docFile, contentBytes)`
	`135`	`+ if err != nil {`
	`136`	`+ return nil, err`
`140`	`137`	`}`
`141`	`138`	`return contentBytes, nil`
`142`	`139`	`}`