Fix emitting warning status logs as visible messages (#445)

pulumi package add terraform module ... used to print "Using Terraform CLI for schema inference" to stdout. This is now fixed. The root cause is that DEBUG level messages were sent at INFO level to the engine on the wire by mistake.

Author: t0yv0

pkg/modprovider/logger.go

@@ -113,29 +113,15 @@ func (l *resourceLogger) Log(ctx context.Context, level tfsandbox.LogLevel, mess
 		return
 	}
 
-	var err error
-	var diagLevel diag.Severity
-	switch level {
-	case tfsandbox.Debug:
-		diagLevel = diag.Debug
-	case tfsandbox.Info:
-		diagLevel = diag.Info
-	case tfsandbox.Warn:
-		diagLevel = diag.Warning
-	case tfsandbox.Error:
-		diagLevel = diag.Error
-	default:
-		diagLevel = diag.Info
-	}
+	diagLevel := asSeverity(level)
 
 	if diagLevel == diag.Error && isMissingCredentialsErrorFromAWS(message) {
 		// for AWS provider, we can detect missing credentials errors and provide a more helpful message
 		// that is specific to Pulumi users.
 		message = awsMissingCredentialsErrorMessage
 	}
 
-	err = l.hc.Log(ctx, diagLevel, l.urn, message)
-
+	err := l.hc.Log(ctx, diagLevel, l.urn, message)
 	contract.IgnoreError(err)
 }
 
@@ -144,20 +130,30 @@ func (l *resourceLogger) LogStatus(ctx context.Context, level tfsandbox.LogLevel
 		return
 	}
 
-	var err error
+	// warnings and errors should not be Status messages
+	switch level {
+	case tfsandbox.Warn, tfsandbox.Error:
+		l.Log(ctx, level, message)
+		return
+	}
+
+	err := l.hc.LogStatus(ctx, asSeverity(level), l.urn, message)
+	contract.IgnoreError(err)
+}
+
+func asSeverity(level tfsandbox.LogLevel) diag.Severity {
 	var diagLevel diag.Severity
 	switch level {
+	case tfsandbox.Debug:
+		diagLevel = diag.Debug
 	case tfsandbox.Info:
 		diagLevel = diag.Info
 	case tfsandbox.Warn:
+		diagLevel = diag.Warning
 	case tfsandbox.Error:
-		l.Log(ctx, level, message)
-		return
+		diagLevel = diag.Error
 	default:
 		diagLevel = diag.Info
 	}
-
-	err = l.hc.LogStatus(ctx, diagLevel, l.urn, message)
-
-	contract.IgnoreError(err)
+	return diagLevel
 }