Merge pull request #3381 from puppetlabs/maint-simple-rubo-update

Update rubocop 1.9.0 -> 1.72 to be compatible with Ruby 3

Author: gavindidrichsen

.gitignore

@@ -21,7 +21,7 @@
 
 ## Environment normalization:
 /.bundle/
-/vendor/bundle
+/vendor/
 /lib/bundler/man/
 
 Gemfile.lock

.rubocop.yml

@@ -13,340 +13,4 @@ AllCops:
     - site-modules/**/*
     - tasks/**/*
   SuggestExtensions: false
-  TargetRubyVersion: 2.5
-
-# Layout cops
-# https://docs.rubocop.org/rubocop/cops_layout.html
-
-Layout/BeginEndAlignment:
-  Enabled: true
-
-Layout/ClosingHeredocIndentation:
-  Enabled: false
-
-Layout/EmptyLineAfterGuardClause:
-  Enabled: false
-
-Layout/EmptyLinesAroundAttributeAccessor:
-  Enabled: true
-
-Layout/EndOfLine:
-  EnforcedStyle: lf
-
-Layout/HashAlignment:
-  EnforcedColonStyle:
-    - key
-    - table
-  EnforcedHashRocketStyle:
-    - key
-    - table
-
-Layout/HeredocIndentation:
-  Enabled: false
-
-Layout/LineLength:
-  Max: 120
-
-Layout/SpaceAroundMethodCallOperator:
-  Enabled: true
-
-Layout/SpaceBeforeBrackets:
-  Enabled: true
-
-Layout/TrailingWhitespace:
-  AllowInHeredoc: true
-
-# Lint cops
-# https://docs.rubocop.org/rubocop/cops_lint.html
-
-Lint/AmbiguousAssignment:
-  Enabled: true
-
-Lint/BinaryOperatorWithIdenticalOperands:
-  Enabled: true
-
-Lint/ConstantDefinitionInBlock:
-  Enabled: true
-
-Lint/DeprecatedConstants:
-  Enabled: true
-
-Lint/DeprecatedOpenSSLConstant:
-  Enabled: true
-
-Lint/DuplicateBranch:
-  Enabled: true
-
-Lint/DuplicateElsifCondition:
-  Enabled: true
-
-Lint/DuplicateRegexpCharacterClassElement:
-  Enabled: true
-
-Lint/DuplicateRequire:
-  Enabled: true
-
-Lint/DuplicateRescueException:
-  Enabled: true
-
-Lint/EmptyBlock:
-  Enabled: true
-  Exclude:
-    - bolt-modules/**/lib/puppet/functions/**/*
-    - lib/bolt/transport/orch.rb
-    - spec/**/*
-
-Lint/EmptyClass:
-  Enabled: true
-
-Lint/EmptyConditionalBody:
-  Enabled: true
-
-Lint/EmptyFile:
-  Enabled: true
-
-Lint/FloatComparison:
-  Enabled: true
-
-Lint/HashCompareByIdentity:
-  Enabled: false
-
-Lint/IdentityComparison:
-  Enabled: true
-
-Lint/LambdaWithoutLiteralBlock:
-  Enabled: true
-
-Lint/MissingSuper:
-  Enabled: false
-
-Lint/MixedRegexpCaptureTypes:
-  Enabled: false
-
-Lint/NoReturnInBeginEndBlocks:
-  Enabled: true
-
-Lint/OutOfRangeRegexpRef:
-  Enabled: true
-
-Lint/RaiseException:
-  Enabled: true
-
-Lint/RedundantDirGlobSort:
-  Enabled: true
-
-Lint/RedundantSafeNavigation:
-  Enabled: true
-
-Lint/SelfAssignment:
-  Enabled: true
-
-Lint/StructNewOverride:
-  Enabled: true
-
-Lint/SuppressedException:
-  Exclude:
-    - lib/bolt/shell/bash.rb
-    - lib/bolt/module_installer.rb
-
-Lint/ToEnumArguments:
-  Enabled: true
-
-Lint/TopLevelReturnWithArgument:
-  Enabled: true
-
-Lint/TrailingCommaInAttributeDeclaration:
-  Enabled: true
-
-Lint/UnexpectedBlockArity:
-  Enabled: true
-
-Lint/UnmodifiedReduceAccumulator:
-  Enabled: true
-
-Lint/UnreachableLoop:
-  Enabled: true
-
-Lint/UselessMethodDefinition:
-  Enabled: false
-
-Lint/UselessTimes:
-  Enabled: true
-
-# Metrics cops
-# https://docs.rubocop.org/rubocop/cops_metrics.html
-
-Metrics/AbcSize:
-  Enabled: false
-
-Metrics/BlockLength:
-  Enabled: false
-
-Metrics/BlockNesting:
-  Enabled: false
-
-Metrics/ClassLength:
-  Enabled: false
-
-Metrics/CyclomaticComplexity:
-  Enabled: false
-
-Metrics/MethodLength:
-  Enabled: false
-
-Metrics/ModuleLength:
-  Enabled: false
-
-Metrics/ParameterLists:
-  Enabled: false
-
-Metrics/PerceivedComplexity:
-  Enabled: false
-
-# Style cops
-# https://docs.rubocop.org/rubocop/cops_style.html
-
-Style/AccessModifierDeclarations:
-  Enabled: false
-
-Style/AccessorGrouping:
-  Enabled: true
-
-Style/ArgumentsForwarding:
-  Enabled: true
-
-Style/ArrayCoercion:
-  Enabled: true
-
-Style/BisectedAttrAccessor:
-  Enabled: true
-
-Style/BlockDelimiters:
-  Enabled: false
-
-Style/CaseLikeIf:
-  Enabled: true
-
-Style/CollectionCompact:
-  Enabled: true
-
-Style/ClassEqualityComparison:
-  Enabled: true
-
-Style/CombinableLoops:
-  Enabled: true
-
-Style/Documentation:
-  Enabled: false
-
-Style/DocumentDynamicEvalDefinition:
-  Enabled: true
-
-Style/DoubleNegation:
-  Enabled: false
-
-Style/EndlessMethod:
-  Enabled: true
-
-Style/ExplicitBlockArgument:
-  Enabled: false
-
-Style/ExponentialNotation:
-  Enabled: true
-
-Style/GlobalStdStream:
-  Enabled: true
-
-Style/GuardClause:
-  Enabled: false
-
-Style/HashAsLastArrayItem:
-  Enabled: false
-
-Style/HashEachMethods:
-  Enabled: true
-
-Style/HashExcept:
-  Enabled: true
-
-Style/HashLikeCase:
-  Enabled: true
-
-Style/HashTransformKeys:
-  Enabled: true
-
-Style/HashTransformValues:
-  Enabled: true
-
-Style/IfUnlessModifier:
-  Enabled: false
-
-Style/KeywordParametersOrder:
-  Enabled: true
-
-Style/MultilineBlockChain:
-  Enabled: false
-
-Style/NegatedIfElseCondition:
-  Enabled: true
-
-Style/NilLambda:
-  Enabled: true
-
-Style/NumericLiterals:
-  Enabled: false
-
-Style/NumericPredicate:
-  Enabled: false
-
-Style/OptionalBooleanParameter:
-  Enabled: false
-
-Style/RedundantArgument:
-  Enabled: true
-
-Style/RedundantAssignment:
-  Enabled: true
-
-Style/RedundantFetchBlock:
-  Enabled: true
-
-Style/RedundantFileExtensionInRequire:
-  Enabled: true
-
-Style/RedundantRegexpCharacterClass:
-  Enabled: true
-
-Style/RedundantRegexpEscape:
-  Enabled: true
-
-Style/RedundantSelfAssignment:
-  Enabled: true
-
-Style/RegexpLiteral:
-  Enabled: true
-  EnforcedStyle: mixed
-
-Style/SafeNavigation:
-  Enabled: false
-
-Style/SingleArgumentDig:
-  Enabled: false
-
-Style/SlicingWithRange:
-  Enabled: false
-
-Style/SoleNestedConditional:
-  Enabled: false
-
-Style/StderrPuts:
-  Enabled: false
-
-Style/StringConcatenation:
-  Enabled: false
-
-Style/StringLiterals:
-  Enabled: false
-
-Style/SwapValues:
-  Enabled: true
+  TargetRubyVersion: 3.0