(maint) - Fix broken default CAT modules dependency checks

Author: jordanbreen28

bin/dependency-checker

@@ -19,12 +19,6 @@ OptionParser.new do |opts|
     options[:namespace] = namespace
   end
 
-  opts.on('-b bolt_project', '--bolt-project bolt_project', 'Check all modules within a bolt-project.yaml file.') do |bolt_project|
-    raise 'You must specify a valid bolt-project.yaml' unless File.exist?(bolt_project) || bolt_project.end_with?('.yaml')
-    
-    options[:bolt_project] = bolt_project
-  end
-
   opts.on('--endorsement endorsement', 'Filter a namespace search by endorsement (supported/approved/partner).') do |endorsement|
     raise 'You may only filter by one endorsement at a time' if options[:endorsement]
 

lib/dependency_checker/runner.rb

@@ -8,7 +8,7 @@
 
 # Main runner for DependencyChecker
 module DependencyChecker
-  class Runner
+  class Runner # rubocop:disable Metrics/ClassLength
     attr_reader :problems
 
     def initialize(verbose = false, forge_hostname = nil, forge_token = nil)
@@ -184,10 +184,12 @@ def return_modules(path)
         raise "*Error:* Ensure syntax of #{path} file is valid YAML or JSON"
       end
 
-      # transform from IAC supported module hash to simple list
-      modules = modules.filter_map { |_key, val| val['puppet_module'] } if modules.is_a? Hash
-
-      modules
+      # transform from CAT supported module hash to simple list
+      if path.end_with? '/content-and-tooling-team/modules/list.json'
+        modules.filter_map { |key, _val| key['name'] } if modules.is_a? Array
+      elsif modules.is_a? Hash
+        modules.filter_map { |_key, val| val['puppet_module'] }
+      end
     end
 
     # Post message to terminal