PE Provided install.bash Creates Broken Symlinks

[smhanes15]

Describe the Bug

The install.bash script provided with PE (at least version 2021.7.8) creates symlinks in /usr/local/bin to targets that might not actually exist, resulting in broken links. This results in symlink permissions being evaluated instead of target permissions, which in turn triggers a finding in STIG checks such as: find -L /bin /sbin /usr/bin /usr/sbin /usr/local/bin /usr/local/sbin -perm /022 -exec ls -l {} ;

Expected Behavior

The function inside the install.bash script that creates symlinks should only create those links if the target exists.

Steps to Reproduce

Steps to reproduce the behavior:

1. On a non PE server run: curl -k https://pe_master.example.com:8140/packages/current/install.bash | sudo bash
2. Once complete, run: ls -l /usr/local/bin/ and observe broken symlink

Environment

• Version 2021.7.8
• Platform RHEL-8

[jordi-garcia]

Hi,
Puppet Support is reviewing the issues raised via this repo.

We have checked the behaviour highlighted in this ticket and can confirm that when using PE 2023.8.4 this issue still persist. In our case the output below shows pe-man -> /opt/puppetlabs/bin/pe-man is a broken link and agree that it shouldn't be there in principle.

[root@pe-node-h9omv7-0 ~]# ls -l /usr/local/bin/
total 0
lrwxrwxrwx. 1 root root 26 Jul 18 13:20 facter -> /opt/puppetlabs/bin/facter
lrwxrwxrwx. 1 root root 26 Jul 18 13:20 pe-man -> /opt/puppetlabs/bin/pe-man
lrwxrwxrwx. 1 root root 26 Jul 18 13:20 puppet -> /opt/puppetlabs/bin/puppet
[root@pe-node-h9omv7-0 ~]# ls -ltra /opt/puppetlabs/bin/
facter     puppet     pxp-agent

We are going to raise a PE ticket to capture this issue and resolve it in future releases.

Many thanks for your contribution.

Best regards,

Jordi Garcia

[jordi-garcia]

For ref, engineering ticket PA-7649