(maint) Corrects legacy macOS facts

Prior to this commit, the legacy facts plugin misidentified the
correlation between legacy macOS (formerly OSX) facts and the modern
structured facts.

This commit corrects the modern macOS facts.

Author: mhashizume

lib/puppet-lint/plugins/legacy_facts/legacy_facts.rb

@@ -62,11 +62,11 @@
     'lsbminordistrelease'         => "facts['os']['distro']['release']['minor']",
     'lsbrelease'                  => "facts['os']['distro']['release']['specification']",
     'macaddress'                  => "facts['networking']['mac']",
-    'macosx_buildversion'         => "facts['os']['build']",
-    'macosx_productname'          => "facts['os']['product']",
-    'macosx_productversion'       => "facts['os']['version']['full']",
-    'macosx_productversion_major' => "facts['os']['version']['major']",
-    'macosx_productversion_minor' => "facts['os']['version']['minor']",
+    'macosx_buildversion'         => "facts['os']['macosx']['build']",
+    'macosx_productname'          => "facts['os']['macosx']['product']",
+    'macosx_productversion'       => "facts['os']['macosx']['version']['full']",
+    'macosx_productversion_major' => "facts['os']['macosx']['version']['major']",
+    'macosx_productversion_minor' => "facts['os']['macosx']['version']['minor']",
     'manufacturer'                => "facts['dmi']['manufacturer']",
     'memoryfree'                  => "facts['memory']['system']['available']",
     'memorysize'                  => "facts['memory']['system']['total']",