Merge pull request #149 from ekohl/drop-collection_matchers-dependency

Drop rspec-collection_matchers dependency

Author: jordanbreen28

Gemfile

@@ -5,7 +5,6 @@ gemspec
 group :test do
   gem 'rake'
   gem 'rspec-its', '~> 1.0'
-  gem 'rspec-collection_matchers', '~> 1.0'
 
   gem 'rspec', '~> 3.0'
   gem 'json'

spec/spec_helper.rb

@@ -12,7 +12,6 @@
 
 require 'puppet-lint'
 require 'rspec/its'
-require 'rspec/collection_matchers'
 begin
   require 'rspec/json_expectations'
 rescue LoadError, SyntaxError

spec/unit/puppet-lint/checks_spec.rb

@@ -31,7 +31,7 @@
         end
 
         it 'creates a syntax error problem for the file' do
-          expect(instance.problems).to have(1).problem
+          expect(instance.problems.size).to eq(1)
           expect(instance.problems.first).to include(
             kind: :error,
             check: :syntax,
@@ -53,7 +53,7 @@
         end
 
         it 'creates a syntax error problem for the file' do
-          expect(instance.problems).to have(1).problem
+          expect(instance.problems.size).to eq(1)
           expect(instance.problems.first).to include(
             kind: :error,
             check: :syntax,

spec/unit/puppet-lint/ignore_overrides_spec.rb

@@ -13,7 +13,7 @@
     end
 
     it 'detects three problems' do
-      expect(problems).to have(3).problems
+      expect(problems.size).to eq(3)
     end
 
     it 'has two warnings' do
@@ -36,7 +36,7 @@
     end
 
     it 'detects three problems' do
-      expect(problems).to have(3).problems
+      expect(problems.size).to eq(3)
     end
 
     it 'has two warnings' do
@@ -62,7 +62,7 @@
     end
 
     it 'detects four problems' do
-      expect(problems).to have(4).problems
+      expect(problems.size).to eq(4)
     end
 
     it 'has two warnings' do
@@ -89,7 +89,7 @@
     end
 
     it 'detects four problems' do
-      expect(problems).to have(4).problems
+      expect(problems.size).to eq(4)
     end
 
     it 'has two warnings' do
@@ -107,7 +107,7 @@
     let(:code) { '"true" # lint:ignore:quoted_booleans lint:ignore:double_quoted_string a reason' }
 
     it 'detects 1 problems' do
-      expect(problems).to have(1).problems
+      expect(problems.size).to eq(1)
     end
 
     it 'has one ignored problems' do
@@ -129,7 +129,7 @@
     end
 
     it 'detects 2 problems' do
-      expect(problems).to have(2).problems
+      expect(problems.size).to eq(2)
     end
 
     it 'ignores both problems' do