(MAINT) Rubocop fixes for puppet-lint/plugins

Author: chelnak

spec/puppet-lint/plugins/check_classes/arrow_on_right_operand_line_spec.rb

@@ -12,7 +12,7 @@
           END
         end
 
-        it 'should not detect any problems' do
+        it 'does not detect any problems' do
           expect(problems).to have(0).problems
         end
       end
@@ -25,20 +25,20 @@
           END
         end
 
-        it 'should detect a problem' do
+        it 'detects a problem' do
           expect(problems).to have(1).problem
         end
 
-        it 'should create a warning' do
+        it 'creates a warning' do
           expect(problems).to contain_warning(msg).on_line(1).in_column(31)
         end
 
         context 'with fix enabled' do
-          before do
+          before(:each) do
             PuppetLint.configuration.fix = true
           end
 
-          after do
+          after(:each) do
             PuppetLint.configuration.fix = false
           end
 
@@ -49,11 +49,11 @@
             END
           end
 
-          it 'should fix the problem' do
+          it 'fixes the problem' do
             expect(problems).to contain_fixed(msg).on_line(1).in_column(31)
           end
 
-          it 'should move the arrow to before the right operand' do
+          it 'moves the arrow to before the right operand' do
             expect(manifest).to eq(fixed)
           end
         end
@@ -67,7 +67,7 @@
           END
         end
 
-        it 'should not detect any problems' do
+        it 'does not detect any problems' do
           expect(problems).to have(0).problems
         end
       end
@@ -83,11 +83,11 @@
           END
         end
 
-        it 'should detect a problem' do
+        it 'detects a problem' do
           expect(problems).to have(1).problem
         end
 
-        it 'should create a warning' do
+        it 'creates a warning' do
           expect(problems).to contain_warning(msg).on_line(1).in_column(30)
         end
 
@@ -110,11 +110,11 @@
             END
           end
 
-          it 'should fix the problem' do
+          it 'fixes the problem' do
             expect(problems).to contain_fixed(msg).on_line(1).in_column(30)
           end
 
-          it 'should move the arrow to before the right operand' do
+          it 'moves the arrow to before the right operand' do
             expect(manifest).to eq(fixed)
           end
         end
@@ -128,11 +128,11 @@
           END
         end
 
-        it 'should detect a problem' do
+        it 'detects a problem' do
           expect(problems).to have(1).problem
         end
 
-        it 'should create a warning' do
+        it 'creates a warning' do
           expect(problems).to contain_warning(msg).on_line(1).in_column(30)
         end
 
@@ -152,11 +152,11 @@
             END
           end
 
-          it 'should fix the problem' do
+          it 'fixes the problem' do
             expect(problems).to contain_fixed(msg).on_line(1).in_column(30)
           end
 
-          it 'should move the arrow to before the right operand' do
+          it 'moves the arrow to before the right operand' do
             expect(manifest).to eq(fixed)
           end
         end

spec/puppet-lint/plugins/check_classes/autoloader_layout_spec.rb

@@ -5,7 +5,7 @@
     let(:code) { 'class foo::bar { }' }
     let(:path) { 'foo/manifests/bar.pp' }
 
-    it 'should not detect any problems' do
+    it 'does not detect any problems' do
       expect(problems).to have(0).problems
     end
   end
@@ -14,7 +14,7 @@
     let(:code) { 'define foo::bar::baz() { }' }
     let(:path) { 'foo/manifests/bar/baz.pp' }
 
-    it 'should not detect any problems' do
+    it 'does not detect any problems' do
       expect(problems).to have(0).problems
     end
   end
@@ -23,7 +23,7 @@
     let(:code) { 'class foo { }' }
     let(:path) { 'foo/manifests/init.pp' }
 
-    it 'should not detect any problems' do
+    it 'does not detect any problems' do
       expect(problems).to have(0).problems
     end
   end
@@ -33,11 +33,11 @@
     let(:path) { 'foo/manifests/init.pp' }
     let(:msg) { 'foo::bar not in autoload module layout' }
 
-    it 'should only detect a single problem' do
+    it 'only detects a single problem' do
       expect(problems).to have(1).problem
     end
 
-    it 'should create an error' do
+    it 'creates an error' do
       expect(problems).to contain_error(msg).on_line(1).in_column(7)
     end
   end
@@ -55,7 +55,7 @@ class {'foo':
 
     let(:path) { 'bar/manifests/init.pp' }
 
-    it 'should not detect any problems' do
+    it 'does not detect any problems' do
       expect(problems).to have(0).problems
     end
   end
@@ -64,41 +64,41 @@ class {'foo':
     let(:code) { 'class foo { }' }
     let(:path) { 'puppet-foo/manifests/init.pp' }
 
-    it 'should detect a single problem' do
+    it 'detects a single problem' do
       expect(problems).to have(1).problems
     end
   end
 
   context 'foo in puppet-foo/manifests/bar.pp with relative option' do
-    before do
+    before(:each) do
       PuppetLint.configuration.relative = true
     end
 
-    after do
+    after(:each) do
       PuppetLint.configuration.relative = false
     end
 
     let(:code) { 'class foo { }' }
     let(:path) { 'puppet-foo/manifests/bar.pp' }
 
-    it 'should detect a single problem' do
+    it 'detects a single problem' do
       expect(problems).to have(1).problems
     end
   end
 
   context 'foo in puppet-foo/manifests/init.pp with relative option' do
-    before do
+    before(:each) do
       PuppetLint.configuration.relative = true
     end
 
-    after do
+    after(:each) do
       PuppetLint.configuration.relative = false
     end
 
     let(:code) { 'class foo { }' }
     let(:path) { 'puppet-foo/manifests/init.pp' }
 
-    it 'should not detect any problems' do
+    it 'does not detect any problems' do
       expect(problems).to have(0).problems
     end
   end

spec/puppet-lint/plugins/check_classes/class_inherits_from_params_class_spec.rb

@@ -11,11 +11,11 @@ class foo($bar = $name) inherits foo::params { }
       END
     end
 
-    it 'should only detect a single problem' do
+    it 'only detects a single problem' do
       expect(problems).to have(1).problem
     end
 
-    it 'should create a warning' do
+    it 'creates a warning' do
       expect(problems).to contain_warning(msg).on_line(2).in_column(42)
     end
   end
@@ -32,7 +32,7 @@ class myclass {
       END
     end
 
-    it 'should not detect any problems' do
+    it 'does not detect any problems' do
       expect(problems).to have(0).problems
     end
   end

spec/puppet-lint/plugins/check_classes/code_on_top_scope_spec.rb

@@ -10,7 +10,7 @@ class foo:bar {
       END
     end
 
-    its(:problems) { should be_empty }
+    its(:problems) { is_expected.to be_empty }
   end
 
   describe 'new lines outside of class-define block' do
@@ -23,7 +23,7 @@ class foo:bar {
       END
     end
 
-    its(:problems) { should be_empty }
+    its(:problems) { is_expected.to be_empty }
   end
 
   describe 'code outside class block' do
@@ -41,8 +41,8 @@ class foo:bar {
     end
 
     its(:problems) do
-      should contain_warning('code outside of class or define block - include')
-      should have(4).problems
+      is_expected.to contain_warning('code outside of class or define block - include')
+      is_expected.to have(4).problems
     end
   end
 end

spec/puppet-lint/plugins/check_classes/inherits_across_namespaces_spec.rb

@@ -6,27 +6,27 @@
   context 'class inheriting from parent in same module namespace' do
     let(:code) { 'class foo::bar inherits foo { }' }
 
-    it 'should not detect any problems' do
+    it 'does not detect any problems' do
       expect(problems).to have(0).problems
     end
   end
 
   context 'class inheriting from sister in same module namespace' do
     let(:code) { 'class foo::bar inherits foo::baz { }' }
 
-    it 'should not detect any problems' do
+    it 'does not detect any problems' do
       expect(problems).to have(0).problems
     end
   end
 
   context 'class inheriting from another module namespace' do
     let(:code) { 'class foo::bar inherits baz { }' }
 
-    it 'should only detect a single problem' do
+    it 'only detects a single problem' do
       expect(problems).to have(1).problem
     end
 
-    it 'should create a warning' do
+    it 'creates a warning' do
       expect(problems).to contain_warning(msg).on_line(1).in_column(25)
     end
   end

spec/puppet-lint/plugins/check_classes/name_contains_uppercase_spec.rb

@@ -6,11 +6,11 @@
     let(:path) { 'foobar/manifests/init.pp' }
     let(:class_msg) { "defined type 'FooBar' contains illegal uppercase" }
 
-    it 'should only detect a single problem' do
+    it 'only detects a single problem' do
       expect(problems).to have(1).problem
     end
 
-    it 'should create an error' do
+    it 'creates an error' do
       expect(problems).to contain_error(class_msg).on_line(1).in_column(8)
     end
   end
@@ -20,11 +20,11 @@
     let(:path) { 'foobar/manifests/init.pp' }
     let(:class_msg) { "class 'FooBar' contains illegal uppercase" }
 
-    it 'should only detect a single problem' do
+    it 'only detects a single problem' do
       expect(problems).to have(1).problem
     end
 
-    it 'should create an error' do
+    it 'creates an error' do
       expect(problems).to contain_error(class_msg).on_line(1).in_column(7)
     end
   end
@@ -34,30 +34,30 @@
     let(:path) { 'foo/manifests/barfoo.pp' }
     let(:class_msg) { "class 'Foo::BarFoo' contains illegal uppercase" }
 
-    it 'should only detect a single problem' do
+    it 'only detects a single problem' do
       expect(problems).to have(1).problem
     end
 
-    it 'should create an error' do
+    it 'creates an error' do
       expect(problems).to contain_error(class_msg).on_line(1).in_column(7)
     end
 
     context 'check fix -' do
-      before do
+      before(:each) do
         PuppetLint.configuration.fix = true
       end
 
-      after do
+      after(:each) do
         PuppetLint.configuration.fix = false
       end
 
       let(:fixed) { code.downcase }
 
-      it 'should create an error' do
+      it 'creates an error' do
         expect(problems).to contain_fixed(class_msg).on_line(1).in_column(7)
       end
 
-      it 'should downcase the class name' do
+      it 'downcases the class name' do
         expect(manifest).to eq(fixed)
       end
     end