Skip to content

Commit 485d1aa

Browse files
authored
Merge pull request #108 from bastelfreak/minitar
minitar: Allow 1.x
2 parents 990c48b + 1b0629b commit 485d1aa

File tree

3 files changed

+6
-3
lines changed

3 files changed

+6
-3
lines changed

Gemfile

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,4 +29,8 @@ group :development do
2929

3030
# Required for testing on Windows
3131
gem 'ffi', platforms: [:x64_mingw]
32+
# puppet-modulebuilder supports minitar 0.x and 1.x
33+
# puppet 8.10.0 can use `tar` (the linux CLI tool) *or* minitar 0.x
34+
# on windows, puppet 8.10 defaults to minitar
35+
gem 'minitar', '~> 0.9', platforms: [:x64_mingw]
3236
end

lib/puppet/modulebuilder/builder.rb

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -339,8 +339,7 @@ def release_name
339339
# header format.
340340
#
341341
# POSIX.1-2001 (which allows paths of infinite length) was adopted by GNU
342-
# tar in 2004 and is supported by minitar 0.7 and above. Unfortunately
343-
# much of the Puppet ecosystem still uses minitar 0.6.1.
342+
# tar in 2004 and is supported by minitar 0.7 and above.
344343
#
345344
# POSIX.1-1998 tar format does not allow for paths greater than 256 bytes,
346345
# or paths that can't be split into a prefix of 155 bytes (max) and

puppet-modulebuilder.gemspec

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ Gem::Specification.new do |spec|
2424
spec.executables = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
2525
spec.require_paths = ['lib']
2626
# minitar and pathspec is required for building Puppet modules
27-
spec.add_dependency 'minitar', '~> 0.9'
27+
spec.add_dependency 'minitar', '>= 0.9', '< 2'
2828
spec.add_dependency 'pathspec', '>= 0.2.1', '< 3.0.0'
2929

3030
spec.add_development_dependency 'voxpupuli-rubocop', '~> 3.0.0'

0 commit comments

Comments
 (0)