Skip to content

Commit 2d6a915

Browse files
Fix CODEOWNER regex to include devx and phoenix
When PRs are raised the CODEOWNERS.md is assessed via regex to determine the allowed approvers. The CODEOWNERS file uses the last matching pattern for each file. In this case, there are two patterns t hat match all files, and the last one is "@puppetlabs/phoenix". This is why only the Phoenix team is being requested for review. To have both teams requested for review, the regex needs to be in one line like this: "@puppetlabs/devx @puppetlabs/phoenix". This way, both teams will be automatically r equested for review when a pull request is opened. Signed-off-by: Gavin Didrichsen <[email protected]>
1 parent 8b51d94 commit 2d6a915

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

CODEOWNERS

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,2 @@
11
# Set the DevX team as the primary owners of the Tool
2-
* @puppetlabs/devx
3-
* @puppetlabs/phoenix
2+
* @puppetlabs/devx @puppetlabs/phoenix

0 commit comments

Comments
 (0)