Skip to content

Commit 2eb46cf

Browse files
committed
(CAT-2453) Implement rubocop plugins that have been moved out
These plugins where previously included in the base rubocop setup but have since been moved out.
1 parent 64d5c1d commit 2eb46cf

File tree

4 files changed

+18
-5
lines changed

4 files changed

+18
-5
lines changed

.rubocop.yml

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,12 @@
11
---
22
inherit_from: .rubocop_todo.yml
33

4-
require: rubocop-rspec
4+
plugins:
5+
- rubocop-rspec
6+
- rubocop-rspec_rails
7+
- rubocop-performance
8+
- rubocop-factory_bot
9+
- rubocop-capybara
510
AllCops:
611
NewCops: enable
712
TargetRubyVersion: '3.1'

.rubocop_todo.yml

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# This configuration was generated by
22
# `rubocop --auto-gen-config`
3-
# on 2025-03-10 20:03:26 UTC using RuboCop version 1.70.0.
3+
# on 2025-09-30 14:08:02 UTC using RuboCop version 1.73.2.
44
# The point is for the user to remove these configuration records
55
# one by one as the offenses are removed from the code base.
66
# Note that changes in the inspected code, or installation of new
@@ -24,6 +24,13 @@ Lint/EmptyClass:
2424
- 'spec/puppet/resource_api/transport_spec.rb'
2525
- 'spec/puppet/resource_api_spec.rb'
2626

27+
# Offense count: 5
28+
# Configuration parameters: MinSize.
29+
Performance/CollectionLiteralInLoop:
30+
Exclude:
31+
- 'lib/puppet/resource_api.rb'
32+
- 'spec/puppet/resource_api/data_type_handling_spec.rb'
33+
2734
# Offense count: 25
2835
# Configuration parameters: IgnoredMetadata.
2936
RSpec/DescribeClass:
@@ -70,8 +77,6 @@ RSpec/SubjectStub:
7077

7178
# Offense count: 24
7279
# This cop supports unsafe autocorrection (--autocorrect-all).
73-
# Configuration parameters: EnforcedStyle.
74-
# SupportedStyles: constant, string
7580
RSpec/VerifiedDoubleReference:
7681
Exclude:
7782
- 'spec/integration/resource_api_spec.rb'

Gemfile

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,9 @@ group :tests do
2222
gem 'rubocop', '~> 1.73.0', require: false
2323
gem 'rubocop-rspec', '~> 3.5.0', require: false
2424
gem 'rubocop-performance', '~> 1.24.0', require: false
25+
gem 'rubocop-rspec_rails', '~> 2.31.0', require: false
26+
gem 'rubocop-factory_bot', '~> 2.27.0', require: false
27+
gem 'rubocop-capybara', '~> 2.22.0', require: false
2528
end
2629

2730
group :development do

spec/puppet/resource_api_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
end
4444

4545
describe Puppet::Provider do
46-
it('has a module prepared for the provider') { expect(described_class.const_get('Minimal', false).name).to eq 'Puppet::Provider::Minimal' }
46+
it('has a module prepared for the provider') { expect(described_class.const_get(:Minimal, false).name).to eq 'Puppet::Provider::Minimal' }
4747
end
4848
end
4949

0 commit comments

Comments
 (0)