Add SimpleProvider tests for custom namevars

As of the prior commit the simple provider correctly matches
not only for types with composite namevars, but also types
with arbitrarily named single namevars. Also, update the
comments at the top of the SimpleProvider class to remove
the note about namevar having to be "name".

Author: seanmil

lib/puppet/resource_api/simple_provider.rb

@@ -6,8 +6,8 @@ module Puppet::ResourceApi
   # This class provides a default implementation for set(), when your resource does not benefit from batching.
   # Instead of processing changes yourself, the `create`, `update`, and `delete` functions, are called for you,
   # with proper logging already set up.
-  # Note that your type needs to use `name` as its namevar, and `ensure` in the conventional way to signal presence
-  # and absence of resources.
+  # Note that your type needs to use `ensure` in the conventional way with values of `prsesent`
+  # and `absent` to signal presence and absence of resources.
   class SimpleProvider
     def set(context, changes)
       namevars = context.type.namevars

spec/puppet/resource_api/simple_provider_spec.rb

@@ -143,6 +143,20 @@ def delete(context, _name); end
       expect(type_def).to receive(:check_schema).never
       provider.set(context, changes)
     end
+
+    context 'when the namevar is not name' do
+      let(:is_values) { { key: 'title', ensure: 'present' } }
+      let(:should_values) { { key: 'title', ensure: 'present' } }
+
+      before(:each) do
+        allow(type_def).to receive(:namevars).and_return([:key])
+      end
+
+      it 'calls update once' do
+        expect(provider).to receive(:update).with(context, 'title', should_values).once
+        provider.set(context, changes)
+      end
+    end
   end
 
   context 'with a single change to update a resource without :is supplied' do
@@ -196,6 +210,20 @@ def delete(context, _name); end
         provider.set(context, changes)
       end
     end
+
+    context 'when the namevar is not name' do
+      let(:is_values) { [{ key: 'title', ensure: 'present' }] }
+      let(:should_values) { { key: 'title', ensure: 'present' } }
+
+      before(:each) do
+        allow(type_def).to receive(:namevars).and_return([:key])
+      end
+
+      it 'calls update once' do
+        expect(provider).to receive(:update).with(context, 'title', should_values).once
+        provider.set(context, changes)
+      end
+    end
   end
 
   context 'with a single change to update a resource with an optional ensure' do
@@ -263,6 +291,20 @@ def delete(context, _name); end
       expect(provider).to receive(:get).never
       provider.set(context, changes)
     end
+
+    context 'when the namevar is not name' do
+      let(:is_values) { { key: 'title', ensure: 'present' } }
+      let(:should_values) { { key: 'title', ensure: 'absent' } }
+
+      before(:each) do
+        allow(type_def).to receive(:namevars).and_return([:key])
+      end
+
+      it 'calls delete once' do
+        expect(provider).to receive(:delete).with(context, 'title').once
+        provider.set(context, changes)
+      end
+    end
   end
 
   context 'with a single change to delete a resource without :is supplied' do
@@ -314,6 +356,20 @@ def delete(context, _name); end
         provider.set(context, changes)
       end
     end
+
+    context 'when the namevar is not name' do
+      let(:is_values) { [{ key: 'title', ensure: 'present' }] }
+      let(:should_values) { { key: 'title', ensure: 'absent' } }
+
+      before(:each) do
+        allow(type_def).to receive(:namevars).and_return([:key])
+      end
+
+      it 'calls delete once' do
+        expect(provider).to receive(:delete).with(context, 'title').once
+        provider.set(context, changes)
+      end
+    end
   end
 
   context 'with multiple changes' do