Merge pull request #304 from seanmil/fix_simple_get_filter_instantiation

Fix instances method with simple_get_filter

Author: LukasAud

lib/puppet/resource_api.rb

@@ -248,7 +248,7 @@ def self.instances
         provider(type_definition.name)
 
         initial_fetch = if type_definition.feature?('simple_get_filter')
-                          my_provider.get(context, [])
+                          my_provider.get(context, nil)
                         else
                           my_provider.get(context)
                         end

spec/acceptance/composite_namevar_spec.rb

@@ -11,7 +11,7 @@
     it 'is returns the values correctly' do
       stdout_str, status = Open3.capture2e("puppet resource #{common_args} composite_namevar")
       expect(stdout_str.strip).to match %r{^composite_namevar}
-      expect(stdout_str.strip).to match %r{Looking for \[\]}
+      expect(stdout_str.strip).to match %r{Looking for nil}
       expect(status).to eq 0
     end
     it 'returns the required resource correctly' do
@@ -20,7 +20,7 @@
       expect(stdout_str.strip).to match %r{ensure\s*=> \'present\'}
       expect(stdout_str.strip).to match %r{package\s*=> \'php\'}
       expect(stdout_str.strip).to match %r{manager\s*=> \'yum\'}
-      expect(stdout_str.strip).to match %r{Looking for \[\]}
+      expect(stdout_str.strip).to match %r{Looking for nil}
       expect(status.exitstatus).to eq 0
     end
     it 'throws error if title is not a matching title_pattern' do

spec/fixtures/test_module/lib/puppet/provider/test_simple_get_filter/test_simple_get_filter.rb

@@ -4,9 +4,7 @@
 # Implementation for the test_simple_get_filter type using the Resource API.
 class Puppet::Provider::TestSimpleGetFilter::TestSimpleGetFilter < Puppet::ResourceApi::SimpleProvider
   def get(_context, names = nil)
-    raise Puppet::DevError, 'names parameter must be provided to TestSimpleGetFilter#get()' if names.nil?
-
-    result = if names.empty?
+    result = if names.nil?
                # rather than fething everything from your large dataset, return a subset of the data that you are happy to show.
                # This will be cached by Puppet. If a resource requested exists in the cache, then no futher calls are made to the provider.
                [{

spec/puppet/resource_api_spec.rb

@@ -2196,7 +2196,7 @@ def set(_context, changes) end
       end
 
       it 'passes through the an empty array to `get`' do
-        expect(provider).to receive(:get).with(anything, []).and_return([])
+        expect(provider).to receive(:get).with(anything, nil).and_return([])
         type.instances
       end