Skip to content

Commit 695de6d

Browse files
committed
(maint) clean up a few off-by-one errors
Upper bounds should not include the `.0` release when comparing
1 parent 17a4212 commit 695de6d

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

Gemfile

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ group :tests do
1818
# these require special dependencies to have everything load properly
1919

2020
# `codecov` 0.1.17 introduced usage of %i[] which is not recognised by JRuby 1.7
21-
if RUBY_PLATFORM == 'java' && Gem::Version.new(RUBY_VERSION) <= Gem::Version.new('2.3.0')
21+
if RUBY_PLATFORM == 'java' && Gem::Version.new(RUBY_VERSION) < Gem::Version.new('2.3.0')
2222
gem 'codecov', '= 0.1.16'
2323
else
2424
gem 'codecov'
@@ -50,9 +50,9 @@ group :tests do
5050
end
5151

5252
# JRuby 1.7 does not like json 2.3.0, jruby 9.1.9.0 has RUBY_VERSION == '2.3.3'
53-
gem 'json', '2.2.0' if RUBY_PLATFORM == 'java' && Gem::Version.new(RUBY_VERSION) <= Gem::Version.new('2.3.0')
53+
gem 'json', '2.2.0' if RUBY_PLATFORM == 'java' && Gem::Version.new(RUBY_VERSION) < Gem::Version.new('2.3.0')
5454
# the last version of parallel to support ruby 2.1
55-
gem 'parallel', '1.13.0' if Gem::Version.new(RUBY_VERSION) <= Gem::Version.new('2.2.0')
55+
gem 'parallel', '1.13.0' if Gem::Version.new(RUBY_VERSION) < Gem::Version.new('2.2.0')
5656

5757
# license_finder does not install on windows using older versions of rubygems.
5858
# ruby 2.4 is confirmed working on appveyor and we only need to run it on the newest gemset anyways

0 commit comments

Comments
 (0)