(maint) make test order really random

The test leakage fixed in the previous commit was only detected by
changing the test order. Removing the seed will ensure that different
test orderings are tested, leading to a more robust test suite as new
issues are discovered and fixed.

Author: DavidS

.rspec

@@ -1,3 +1,3 @@
 --format documentation
 --color
---order rand:123
+--order rand

spec/puppet/resource_api_spec.rb

@@ -1816,20 +1816,22 @@ def set(_context, changes) end
 
     it { expect { described_class.register_type(definition) }.not_to raise_error }
 
-    it 'is seen as a supported feature' do
-      expect(Puppet).not_to receive(:warning).with(%r{Unknown feature detected:.*simple_test_filter})
-      expect { described_class.register_type(definition) }.not_to raise_error
-    end
+    context 'with the type registered' do
+      it 'is seen as a supported feature' do
+        expect(Puppet).not_to receive(:warning).with(%r{Unknown feature detected:.*simple_test_filter})
+        expect { described_class.register_type(definition) }.not_to raise_error
+      end
 
-    it 'passes through the an empty array to `get`' do
-      expect(provider).to receive(:get).with(anything, []).and_return([])
-      type.instances
-    end
+      it 'passes through the an empty array to `get`' do
+        expect(provider).to receive(:get).with(anything, []).and_return([])
+        type.instances
+      end
 
-    it 'passes through the resource title to `get`' do
-      instance = type.new(name: 'bar', ensure: 'present')
-      expect(provider).to receive(:get).with(anything, ['bar']).and_return([])
-      instance.retrieve
+      it 'passes through the resource title to `get`' do
+        instance = type.new(name: 'bar', ensure: 'present')
+        expect(provider).to receive(:get).with(anything, ['bar']).and_return([])
+        instance.retrieve
+      end
     end
   end