Allow multiple namevars with no title_patterns

Resources with multiple namevars can be specified by passing in values as
properties rather than through the title. A valid design choice in some
rare edge-cases. This commit allows it through the title-validation.

Author: DavidS

lib/puppet/resource_api.rb

@@ -355,7 +355,7 @@ def strict_check(current_state)
         return if Puppet.settings[:strict] == :off
 
         strict_check_canonicalize(current_state) if type_definition.feature?('canonicalize')
-        strict_check_title_parameter(current_state) if type_definition.namevars.size > 1
+        strict_check_title_parameter(current_state) if type_definition.namevars.size > 1 && !type_definition.title_patterns.empty?
 
         nil
       end

lib/puppet/resource_api/type_definition.rb

@@ -18,6 +18,10 @@ def feature?(feature)
       (definition[:features] && definition[:features].include?(feature))
     end
 
+    def title_patterns
+      definition[:title_patterns] ||= []
+    end
+
     def validate_schema(definition, attr_key)
       super(definition, attr_key)
       [:title, :provider, :alias, :audit, :before, :consume, :export, :loglevel, :noop, :notify, :require, :schedule, :stage, :subscribe, :tag].each do |name|

spec/puppet/resource_api_spec.rb

@@ -1055,15 +1055,60 @@ def set(_context, changes) end
     end
 
     describe 'the registered type' do
-      subject(:type) { Puppet::Type.type(:with_patterns) }
+      subject(:type) { Puppet::Type.type(:multiple) }
 
       it { is_expected.not_to be_nil }
       it { expect(type.parameters).to eq [:package, :manager] }
     end
 
+    describe "the type's class" do
+      let(:provider_class) do
+        Class.new do
+          def get(_context)
+            [{ package: 'php', manager: 'yum', ensure: 'present' }]
+          end
+
+          def set(_context, _changes); end
+        end
+      end
+      let(:type_class) { Puppet::Type.type(:multiple) }
+
+      before(:each) do
+        stub_const('Puppet::Provider::Multiple', Module.new)
+        stub_const('Puppet::Provider::Multiple::Multiple', provider_class)
+      end
+
+      describe '.instances' do
+        it 'uses the title provided by the provider' do
+          expect(type_class.instances[0].title).to eq(manager: 'yum', package: 'php')
+        end
+      end
+
+      context 'when flushing an instance' do
+        let(:provider_instance) { instance_double(provider_class, 'provider_instance') }
+
+        before(:each) do
+          allow(provider_class).to receive(:new).and_return(provider_instance)
+        end
+
+        after(:each) do
+          # reset cached provider between tests
+          type_class.instance_variable_set(:@my_provider, nil)
+        end
+
+        it 'uses the attributes when setting values' do
+          allow(provider_instance).to receive(:get).and_return([{ package: 'php', manager: 'yum', ensure: 'present' }])
+          expect(provider_instance).to receive(:set) { |_context, changes|
+            expect(changes.keys).to eq [{ package: 'php', manager: 'yum' }]
+          }
+          type_class.new(title: 'some title', package: 'php', manager: 'yum', ensure: :absent).flush
+        end
+      end
+    end
+
     context 'with title_patterns' do
       let(:name) { 'with_patterns' }
-      let(:title_patterns) {
+      let(:title_patterns) do
         [
           {
             pattern: %r{^(?<package>.*[^/])/(?<manager>.*)$},
@@ -1074,7 +1119,7 @@ def set(_context, changes) end
             desc: 'Where only the package is provided',
           },
         ]
-      }
+      end
 
       describe 'the registered type' do
         subject(:type) { Puppet::Type.type(:with_patterns) }
@@ -1083,7 +1128,7 @@ def set(_context, changes) end
         it { expect(type.parameters).to eq [:package, :manager] }
       end
 
-      describe 'the type\'s class' do
+      describe "the type's class" do
         let(:provider_class) do
           Class.new do
             def get(_context)