Unsafe BeEq autocorrection

Author: LukasAud

.rubocop_todo.yml

@@ -24,16 +24,6 @@ Lint/EmptyClass:
     - 'spec/puppet/resource_api/transport_spec.rb'
     - 'spec/puppet/resource_api_spec.rb'
 
-# Offense count: 12
-# This cop supports unsafe autocorrection (--autocorrect-all).
-RSpec/BeEq:
-  Exclude:
-    - 'spec/puppet/resource_api/parameter_spec.rb'
-    - 'spec/puppet/resource_api/property_spec.rb'
-    - 'spec/puppet/resource_api/read_only_parameter_spec.rb'
-    - 'spec/puppet/resource_api/transport/wrapper_spec.rb'
-    - 'spec/puppet/resource_api/value_creator_spec.rb'
-
 # Offense count: 25
 # Configuration parameters: IgnoredMetadata.
 RSpec/DescribeClass:

spec/puppet/resource_api/parameter_spec.rb

@@ -25,7 +25,7 @@
 
       expect { parameter.value = 'value' }.to raise_error Exception, 'error'
 
-      expect(parameter.value).to eq nil
+      expect(parameter.value).to be_nil
     end
   end
 
@@ -51,8 +51,8 @@
       let(:munged_value) { true }
       let(:data_type) { Puppet::Pops::Types::PBooleanType.new }
 
-      it { expect(parameter.rs_value).to eq true }
-      it { expect(parameter.value).to eq true }
+      it { expect(parameter.rs_value).to be true }
+      it { expect(parameter.value).to be true }
     end
   end
 end

spec/puppet/resource_api/property_spec.rb

@@ -48,7 +48,7 @@
 
     describe '#insync?' do
       it 'compares using symbols' do
-        expect(ensure_property.insync?(:present)).to eq(true)
+        expect(ensure_property.insync?(:present)).to be(true)
       end
     end
 
@@ -153,7 +153,7 @@
               end
 
               it 'compares using symbols' do
-                expect(ensure_property.insync?(:present)).to eq(true)
+                expect(ensure_property.insync?(:present)).to be(true)
               end
             end
           end
@@ -285,7 +285,7 @@
 
       expect { property.should = 'value' }.to raise_error Exception, 'error'
 
-      expect(property.should).to eq nil
+      expect(property.should).to be_nil
     end
   end
 
@@ -313,7 +313,7 @@
       let(:data_type) { Puppet::Pops::Types::PBooleanType.new }
 
       it { expect(property.should).to eq :true } # rubocop:disable Lint/BooleanSymbol
-      it { expect(property.rs_value).to eq true }
+      it { expect(property.rs_value).to be true }
       it { expect(property.value).to eq :true } # rubocop:disable Lint/BooleanSymbol
     end
   end

spec/puppet/resource_api/read_only_parameter_spec.rb

@@ -29,8 +29,8 @@
     end
 
     context 'when value is not set' do
-      it { expect(read_only_parameter.rs_value).to eq nil }
-      it { expect(read_only_parameter.value).to eq nil }
+      it { expect(read_only_parameter.rs_value).to be_nil }
+      it { expect(read_only_parameter.value).to be_nil }
     end
 
     context 'when value is already set' do

spec/puppet/resource_api/transport/wrapper_spec.rb

@@ -110,7 +110,7 @@ class SomethingSomethingDarkside; end
     context 'when the transport does not support the function' do
       context 'when using respond_to?' do
         it 'returns false' do
-          expect(instance.respond_to?(:wibble)).to eq(false)
+          expect(instance.respond_to?(:wibble)).to be(false)
         end
       end
 
@@ -128,7 +128,7 @@ class SomethingSomethingDarkside; end
 
       context 'when using respond_to?' do
         it 'returns true' do
-          expect(instance.respond_to?(:close)).to eq(true)
+          expect(instance.respond_to?(:close)).to be(true)
         end
       end
 

spec/puppet/resource_api/value_creator_spec.rb

@@ -119,7 +119,7 @@
       let(:param_or_property) { :newparam }
 
       it 'attribute_class has no #call_provider method' do
-        expect(attribute_class.method_defined?(:call_provider)).to eq(false)
+        expect(attribute_class.method_defined?(:call_provider)).to be(false)
       end
 
       context 'when behaviour is set to :namevar' do