Skip to content

Commit efcb8bd

Browse files
Fix rubocop errors
Recent rubocop updates broke the resource_api's CI: ```ruby ➜ puppet-resource_api git:(main) bundle exec rubocop Error: Property AutoCorrect of cop FactoryBot/CreateList is supposed to be a boolean and contextual is not. + set +x ➜ puppet-resource_api git:(main) ``` Although the fix for other repositories was to upgrade rubocop, an upgrade was not possible on this repo because of the `jruby` and `ruby` engine testing. The solution was to pin the rubocop dependencies to the last working nightly versions: ```ruby gem 'rubocop', '~> 1.48.1', require: false gem 'rubocop-rspec', '~> 2.20.0', require: false gem 'rubocop-performance', '~> 1.17.1', require: false ``` Signed-off-by: Gavin Didrichsen <[email protected]>
1 parent 48de666 commit efcb8bd

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

Gemfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,8 @@ group :tests do
2020
# these require special dependencies to have everything load properly
2121
# rubocop 1.48 supports JRuby 9.3+, which includes coverage for versions we support
2222
gem 'rubocop', '~> 1.48.1', require: false
23-
gem 'rubocop-rspec', '~> 2.19', require: false
24-
gem 'rubocop-performance', '~> 1.16', require: false
23+
gem 'rubocop-rspec', '~> 2.20.0', require: false
24+
gem 'rubocop-performance', '~> 1.17.1', require: false
2525
end
2626

2727
group :development do

0 commit comments

Comments
 (0)