(GH-691) Add PDK Defined Type Command

Add `pdk new defined_type` as an available command in VS Code. This also surfaces it as a command in the command palatte as well as the context menus.

Author: jpogran

package.json

@@ -163,6 +163,11 @@
         "category": "Puppet",
         "title": "PDK New Task"
       },
+      {
+        "command": "extension.pdkNewDefinedType",
+        "category": "Puppet",
+        "title": "PDK New Defined type"
+      },
       {
         "command": "extension.puppetResource",
         "category": "Puppet",
@@ -267,6 +272,9 @@
         {
           "command": "extension.pdkNewTask"
         },
+        {
+          "command": "extension.pdkNewDefinedType"
+        },
         {
           "command": "extension.puppetResource",
           "when": "editorLangId == 'puppet'"
@@ -292,15 +300,20 @@
           "command": "extension.pdkNewTask",
           "group": "pdk@3"
         },
+        {
+          "when": "editorLangId == 'puppet'",
+          "command": "extension.pdkNewDefinedType",
+          "group": "pdk@4"
+        },
         {
           "when": "editorLangId == 'puppet' ",
           "command": "extension.pdkValidate",
-          "group": "pdk@4"
+          "group": "pdk@5"
         },
         {
           "when": "editorLangId == 'puppet'",
           "command": "extension.pdkTestUnit",
-          "group": "pdk@5"
+          "group": "pdk@6"
         },
         {
           "when": "editorLangId == 'puppet'",
@@ -326,14 +339,19 @@
         },
         {
           "when": "editorLangId == 'puppet'",
-          "command": "extension.pdkValidate",
+          "command": "extension.pdkNewDefinedType",
           "group": "pdk@3"
         },
         {
           "when": "editorLangId == 'puppet'",
-          "command": "extension.pdkTestUnit",
+          "command": "extension.pdkValidate",
           "group": "pdk@4"
         },
+        {
+          "when": "editorLangId == 'puppet'",
+          "command": "extension.pdkTestUnit",
+          "group": "pdk@5"
+        },
         {
           "when": "editorLangId == 'puppet'",
           "command": "puppet.puppetShowNodeGraphToSide",

src/feature/PDKFeature.ts

@@ -34,6 +34,12 @@ export class PDKFeature implements IFeature {
       }),
     );
     logger.debug('Registered ' + PDKCommandStrings.PdkNewTaskCommandId + ' command');
+    context.subscriptions.push(
+      vscode.commands.registerCommand(PDKCommandStrings.PdkNewDefinedTypeCommandId, () => {
+        this.pdkNewDefinedTypeCommand();
+      }),
+    );
+    logger.debug('Registered ' + PDKCommandStrings.PdkNewTaskCommandId + ' command');
     context.subscriptions.push(
       vscode.commands.registerCommand(PDKCommandStrings.PdkValidateCommandId, () => {
         this.pdkValidateCommand();
@@ -110,6 +116,21 @@ export class PDKFeature implements IFeature {
     });
   }
 
+  private pdkNewDefinedTypeCommand() {
+    const nameOpts: vscode.QuickPickOptions = {
+      placeHolder: 'Enter a name for the new Puppet defined type',
+      matchOnDescription: true,
+      matchOnDetail: true,
+    };
+    vscode.window.showInputBox(nameOpts).then((typeName) => {
+      this.terminal.sendText(`pdk new defined_type ${typeName}`);
+      this.terminal.show();
+      if (reporter) {
+        reporter.sendTelemetryEvent(PDKCommandStrings.PdkNewDefinedTypeCommandId);
+      }
+    });
+  }
+
   private pdkValidateCommand() {
     this.terminal.sendText(`pdk validate`);
     this.terminal.show();

src/messages.ts

@@ -79,6 +79,7 @@ export class PDKCommandStrings {
   static PdkNewModuleCommandId = 'extension.pdkNewModule';
   static PdkNewClassCommandId = 'extension.pdkNewClass';
   static PdkNewTaskCommandId = 'extension.pdkNewTask';
+  static PdkNewDefinedTypeCommandId = 'extension.pdkNewDefinedType';
   static PdkValidateCommandId = 'extension.pdkValidate';
   static PdkTestUnitCommandId = 'extension.pdkTestUnit';
 }