(GH-446) Deprecate enable-file-cache

As of v0.17.0 of the editor services, the --enable-file-cache option is deprecated.
This commit removes this setting actually doing anything and marks the setting as
deprecated in the package.json.

Author: glennsarti

CHANGELOG.md

@@ -6,6 +6,7 @@ Check [Keep a Changelog](http://keepachangelog.com/) for recommendations on how
 
 ## Unreleased
 
+- ([GH-446](https://github.com/lingua-pupuli/puppet-vscode/issues/446)) Remove deprecated --enable-file-cache option for Editor Services
 - ([GH-440](https://github.com/lingua-pupuli/puppet-vscode/issues/440)) Add a setting for additional modulepath
 - ([GH-447](https://github.com/lingua-pupuli/puppet-vscode/issues/447)) Update puppet-editor-services to [0.17.0](https://github.com/lingua-pupuli/puppet-editor-services/blob/master/CHANGELOG.md#0170---2018-12-14)
 

src/configuration.ts

@@ -11,7 +11,6 @@ export class ConnectionConfiguration implements IConnectionConfiguration {
   public host: string;
   public port: number;
   public timeout: number;
-  public enableFileCache: boolean;
   public debugFilePath: string;
   private settings: ISettings;
 
@@ -21,7 +20,6 @@ export class ConnectionConfiguration implements IConnectionConfiguration {
     this.host = this.settings.editorService.tcp.address;
     this.port = this.settings.editorService.tcp.port;
     this.timeout = this.settings.editorService.timeout;
-    this.enableFileCache = (this.settings.editorService.featureflags.indexOf('filecache') !== -1);
     this.debugFilePath = this.settings.editorService.debugFilePath;
 
     this._puppetInstallType = this.settings.installType;
@@ -187,10 +185,6 @@ export class ConnectionConfiguration implements IConnectionConfiguration {
       args.push('--local-workspace=' + vscode.workspace.workspaceFolders[0].uri.fsPath);
     }
 
-    if (this.enableFileCache) {
-      args.push('--enable-file-cache');
-    }
-
     if (this.debugFilePath !== undefined && this.debugFilePath !== '') {
       args.push('--debug=' + this.debugFilePath);
     }

src/helpers/commandHelper.ts

@@ -14,7 +14,7 @@ export class CommandEnvironmentHelper {
   ): Executable {
     let exe: Executable = {
       command: this.buildExecutableCommand(settings, config),
-      args: this.buildLanguageServerArguments(languageServerpath, settings, config),
+      args: this.buildLanguageServerArguments(languageServerpath, settings),
       options: {},
     };
 
@@ -64,7 +64,6 @@ export class CommandEnvironmentHelper {
   private static buildLanguageServerArguments(
     serverPath: string,
     settings: ISettings,
-    config: IConnectionConfiguration,
   ): string[] {
     let args = [serverPath];
 
@@ -93,9 +92,6 @@ export class CommandEnvironmentHelper {
     if (settings.editorService.modulePath !== undefined && settings.editorService.modulePath !== '') {
       args.push('--puppet-settings=--modulepath,' + settings.editorService.modulePath);
     }
-    if (config.enableFileCache) {
-      args.push('--enable-file-cache');
-    }
     if (settings.editorService.debugFilePath !== undefined && settings.editorService.debugFilePath !== '') {
       args.push('--debug=' + settings.editorService.debugFilePath);
     }

src/interfaces.ts

@@ -39,7 +39,6 @@ export interface IConnectionConfiguration {
   host: string;
   port: number;
   timeout: number;
-  enableFileCache: boolean;
   debugFilePath: string;
   puppetBaseDir: string;
   puppetDir: string;