(GH-2410) Honor specified tcp port

This commit fixes the logic that determines the port used to connect
to the LanguageServer if using the `tcp` protocol. Previously it would
always pick a random unused port to start and connect to the language
server, now it will use the port specified in the configuration if it is
there.

Note, the default value for the `puppet.languageserver.port`
configuration value was removed in this commit. If it was left, there
would always be a value for the port, and the logic would never choose
a random port. This way, the default is actually random as the original
behavior implies but can be set to determinisitic if the user requires.

Author: jpogran

package.json

@@ -300,7 +300,6 @@
         },
         "puppet.languageserver.port": {
           "type": "integer",
-          "default": 8081,
           "description": "The TCP Port of the Puppet Language Server to connect to"
         },
         "puppet.languageserver.timeout": {

src/connection.ts

@@ -182,23 +182,28 @@ export class ConnectionManager implements IConnectionManager {
 
     let connMgr: ConnectionManager = this;
     if(this.connectionConfiguration.protocol === ProtocolType.TCP){
-      // Start a server to get a random port
-      this.logger.debug(logPrefix + 'Creating server process to identify random port');
-      const server = net
-        .createServer()
-        .on('close', () => {
-          this.logger.debug(logPrefix + 'Server process to identify random port disconnected');
-          connMgr.startLanguageServerProcess(localServer.command, localServer.args, localServer.options, callback);
-        })
-        .on('error', err => {
-          throw err;
-        });
-
-      // Listen on random port
-      server.listen(0);
-      this.logger.debug(logPrefix + 'Selected port for local language server: ' + server.address().port);
-      connMgr.connectionConfiguration.port = server.address().port;
-      server.close();
+      if(this.connectionConfiguration.port){
+        this.logger.debug(logPrefix + 'Selected port for local language server: ' + this.connectionConfiguration.port);
+        connMgr.startLanguageServerProcess(localServer.command, localServer.args, localServer.options, callback);
+      }else{
+        // Start a server to get a random port
+        this.logger.debug(logPrefix + 'Creating server process to identify random port');
+        const server = net
+          .createServer()
+          .on('close', () => {
+            this.logger.debug(logPrefix + 'Server process to identify random port disconnected');
+            connMgr.startLanguageServerProcess(localServer.command, localServer.args, localServer.options, callback);
+          })
+          .on('error', err => {
+            throw err;
+          });
+
+        // Listen on random port
+        server.listen(0);
+        this.logger.debug(logPrefix + 'Selected port for local language server: ' + server.address().port);
+        connMgr.connectionConfiguration.port = server.address().port;
+        server.close();
+      }
     }else{
       this.logger.debug(logPrefix + 'STDIO Server process starting');
       connMgr.startLanguageServerProcess(localServer.command, localServer.args, localServer.options, callback);