Skip to content

Commit 7125df0

Browse files
committed
(maint) Use local tsc instead of global
Previously the build script used a global install of typescript instead of the version installed using npm. This version mismatch means new typescript rules or features may break the build. This changes the build process to use the local version with `npm run compile` so that the build script operates the same as running the project inside VS Code.
1 parent 9721e96 commit 7125df0

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

.github/workflows/vscode-ci.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,6 @@ jobs:
5454
shell: pwsh
5555
run: |
5656
npm install -g vsce --silent;
57-
npm install -g typescript --silent;
5857
npm install --silent;
5958
6059
- name: npm build

psakefile.ps1

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ task VendorEditorSyntax -precondition { !(Test-Path (Join-Path $PSScriptRoot 'sy
8888
throw "Unable to vendor Editor Syntax. Missing a release, directory, or git reference configuration item"
8989
}
9090

91-
Invoke-RestMethod -Uri $uri -OutFile $syntaxFilePath -ErrorAction Stop
91+
Invoke-RestMethod -Uri $uri -OutFile $syntaxFilePath -ErrorAction Stop
9292
}
9393

9494
task VendorCytoscape -precondition { !(Test-Path (Join-Path $PSScriptRoot 'vendor\cytoscape')) } {
@@ -98,7 +98,7 @@ task VendorCytoscape -precondition { !(Test-Path (Join-Path $PSScriptRoot 'vendo
9898
}
9999

100100
task CompileTypeScript {
101-
exec { tsc -p ./ }
101+
exec { npm run compile }
102102
}
103103

104104
task Bump {

0 commit comments

Comments
 (0)