Skip to content

Commit 792df9d

Browse files
authored
Merge pull request #587 from jpogran/maint-remove-telemetry-class-wrapper
(maint) Remove TelemetryReporter Wrapper
2 parents bb671a4 + 68d2196 commit 792df9d

File tree

9 files changed

+37
-55
lines changed

9 files changed

+37
-55
lines changed

src/extension.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ import { ConnectionType, ProtocolType, PuppetInstallType, ISettings } from './se
1919
import { ILogger } from './logging';
2020
import { OutputChannelLogger } from './logging/outputchannel';
2121
import { legacySettings, SettingsFromWorkspace } from './settings';
22-
import { Reporter, reporter } from './telemetry/telemetry';
22+
import { reporter } from './telemetry';
2323
import { PuppetModuleHoverFeature } from './feature/PuppetModuleHoverFeature';
2424

2525
const axios = require('axios');
@@ -41,8 +41,6 @@ export function activate(context: vscode.ExtensionContext) {
4141

4242
checkForLegacySettings();
4343

44-
context.subscriptions.push(new Reporter(extContext));
45-
4644
const settings = SettingsFromWorkspace();
4745
const previousInstallType = settings.installType;
4846
configSettings = CreateAggregrateConfiguration(settings);
@@ -114,6 +112,7 @@ export function deactivate() {
114112
if (connectionHandler !== undefined) {
115113
connectionHandler.stop();
116114
}
115+
reporter.dispose();
117116
}
118117

119118
function checkForLegacySettings() {

src/feature/BoltFeature.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { ExtensionContext, commands, window, Uri } from 'vscode';
22
import { IFeature } from '../feature';
33
import * as path from 'path';
44
import * as fs from 'fs';
5-
import { reporter } from '../telemetry/telemetry';
5+
import { reporter } from '../telemetry';
66

77
export class BoltFeature implements IFeature {
88
dispose() { }

src/feature/NodeGraphFeature.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import { IFeature } from "../feature";
77
import { ILogger } from "../logging";
88
import { ConnectionStatus } from '../interfaces';
99
import { CompileNodeGraphRequest, CompileNodeGraphResponse } from '../messages';
10-
import { reporter } from '../telemetry/telemetry';
10+
import { reporter } from '../telemetry';
1111
import * as viz from 'viz.js';
1212
import { ConnectionHandler } from "../handler";
1313
import { ISettings, SettingsFromWorkspace } from '../settings';

src/feature/PDKFeature.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import * as vscode from 'vscode';
44
import { IFeature } from '../feature';
55
import { ILogger } from '../logging';
66
import { PDKCommandStrings } from '../messages';
7-
import { reporter } from '../telemetry/telemetry';
7+
import { reporter } from '../telemetry';
88

99
export class PDKFeature implements IFeature {
1010
private terminal: vscode.Terminal;

src/feature/PuppetResourceFeature.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ import * as vscode from 'vscode';
44
import { IFeature } from '../feature';
55
import { ILogger } from '../logging';
66
import { PuppetCommandStrings, PuppetResourceRequestParams, PuppetResourceRequest, PuppetResourceResponse } from '../messages';
7-
import { reporter } from '../telemetry/telemetry';
7+
import { reporter } from '../telemetry';
88
import { ConnectionStatus } from '../interfaces';
99
import { ConnectionHandler } from '../handler';
1010
import { ISettings, SettingsFromWorkspace } from '../settings';

src/handler.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import { ConnectionType, ProtocolType } from './settings';
66
import { IPuppetStatusBar } from './feature/PuppetStatusBarFeature';
77
import { OutputChannelLogger } from './logging/outputchannel';
88
import { PuppetVersionDetails, PuppetVersionRequest, PuppetCommandStrings } from './messages';
9-
import { reporter } from './telemetry/telemetry';
9+
import { reporter } from './telemetry';
1010
import { puppetFileLangID, puppetLangID} from './extension';
1111
import { IAggregateConfiguration } from './configuration';
1212

src/telemetry.ts

Lines changed: 30 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,30 @@
1+
import * as vscode from 'vscode';
2+
import TelemetryReporter from 'vscode-extension-telemetry';
3+
4+
5+
export const reporter:TelemetryReporter = getTelemetryReporter();
6+
7+
function getTelemetryReporter() {
8+
let pkg = getPackageInfo();
9+
let reporter:TelemetryReporter = new TelemetryReporter(
10+
pkg.name,
11+
pkg.version,
12+
pkg.aiKey
13+
);
14+
return reporter;
15+
}
16+
17+
function getPackageInfo(): IPackageInfo {
18+
let pkg = vscode.extensions.getExtension('jpogran.puppet-vscode');
19+
return {
20+
name: pkg.packageJSON.name,
21+
version: pkg.packageJSON.version,
22+
aiKey: pkg.packageJSON.aiKey
23+
};
24+
}
25+
26+
interface IPackageInfo {
27+
name: string;
28+
version: string;
29+
aiKey: string;
30+
}

src/telemetry/telemetry.ts

Lines changed: 0 additions & 31 deletions
This file was deleted.

src/telemetry/typings/vscode-extension-telemetry.d.ts

Lines changed: 0 additions & 16 deletions
This file was deleted.

0 commit comments

Comments
 (0)