(GH-187) Partial Revert 3690ca2

Previously commit 3690ca2 the Socket connection object was modified for the
STDIO server.  However this was causing issues and was not required.  This
commit partially reverts the changes in 3690ca2 to the TCP Server and
JSON Handler to the parent commit.

Author: glennsarti

server/lib/puppet-languageserver/json_rpc_handler.rb

@@ -37,7 +37,7 @@ module PuppetLanguageServer
   KEY_CODE      = 'code'.freeze
   KEY_MESSAGE   = 'message'.freeze
 
-  class JSONRPCHandler < PuppetVSCode::SocketConnection
+  class JSONRPCHandler < PuppetVSCode::SimpleTCPServerConnection
     def initialize(*_options)
       @key_jsonrpc = KEY_JSONRPC
       @key_id = KEY_ID

server/lib/puppet-vscode/simple_tcp_server.rb

@@ -4,8 +4,9 @@
 # http://stackoverflow.com/questions/29858113/unable-to-make-socket-accept-non-blocking-ruby-2-2
 
 module PuppetVSCode
-  class SocketConnection
+  class SimpleTCPServerConnection
     attr_accessor :socket
+    attr_accessor :simple_tcp_server
 
     # Methods to override
     def post_init
@@ -34,21 +35,6 @@ def send_data(data)
       true
     end
 
-    # @api public
-    def close_connection_after_writing
-      true
-    end
-
-    # @api public
-    def close_connection
-      true
-    end
-  end
-
-  class SimpleTCPServerConnection < SocketConnection
-    attr_accessor :socket
-    attr_accessor :simple_tcp_server
-
     # @api public
     def close_connection_after_writing
       socket.flush