Merge pull request #662 from jpogran/gh-642-eslint-migration

(GH-642) Migrate to ES Lint

Author: glennsarti

.eslintignore

@@ -0,0 +1,5 @@
+assets
+node_modules
+out
+src/test
+vendor

.eslintrc.json

@@ -0,0 +1,59 @@
+/*
+👋 Hi! This file was autogenerated by tslint-to-eslint-config.
+https://github.com/typescript-eslint/tslint-to-eslint-config
+
+It represents the closest reasonable ESLint configuration to this
+project's original TSLint configuration.
+
+We recommend eventually switching this configuration to extend from
+the recommended rulesets in typescript-eslint.
+https://github.com/typescript-eslint/tslint-to-eslint-config/blob/master/docs/FAQs.md
+
+Happy linting! 💖
+*/
+{
+  "env": { "browser": true, "es6": true, "node": true },
+  "parser": "@typescript-eslint/parser",
+  "parserOptions": { "sourceType": "module" },
+  "plugins": ["@typescript-eslint", "prettier"],
+  "extends": [
+    "eslint:recommended",
+    "plugin:@typescript-eslint/eslint-recommended",
+    "plugin:@typescript-eslint/recommended",
+    "plugin:prettier/recommended",
+    "prettier"
+  ],
+  "rules": {
+    "no-return-await": "error",
+    "block-scoped-var": "error",
+    "default-case": "error",
+    "default-case-last": "error",
+    "default-param-last": "error",
+    "guard-for-in": "error",
+    "no-extend-native": "error",
+    "no-invalid-this": "error",
+    "no-useless-call": "error",
+    "no-void": "error",
+    "wrap-iife": "error",
+    "no-console": "error",
+    "no-await-in-loop": "error",
+    "no-template-curly-in-string": "error",
+    "require-atomic-updates": "error",
+    "no-useless-backreference": "error",
+    "@typescript-eslint/class-name-casing": "warn",
+    "@typescript-eslint/member-delimiter-style": [
+      "warn",
+      {
+        "multiline": { "delimiter": "semi", "requireLast": true },
+        "singleline": { "delimiter": "semi", "requireLast": false }
+      }
+    ],
+    "@typescript-eslint/no-unused-expressions": "warn",
+    "@typescript-eslint/semi": ["warn", "always"],
+    "@typescript-eslint/interface-name-prefix": "off",
+    "curly": "warn",
+    "eqeqeq": ["warn", "always"],
+    "no-redeclare": "warn",
+    "no-throw-literal": "warn"
+  }
+}

.vscode/extensions.json

@@ -1,8 +1,8 @@
 {
   "recommendations": [
+    "dbaeumer.vscode-eslint",
     "eamodio.gitlens",
     "esbenp.prettier-vscode",
-    "ms-vscode.vscode-typescript-tslint-plugin",
     "wwm.better-align",
     "rebornix.Ruby"
   ]

.vscode/settings.json

@@ -1,31 +1,55 @@
-// Place your settings in this file to overwrite default and user settings.
 {
+  "editor.formatOnSave": true,
+  "editor.formatOnType": true,
   "editor.insertSpaces": true,
   "editor.tabSize": 2,
   "editor.trimAutoWhitespace": true,
-
   "files.encoding": "utf8",
-  // The default end of line character. Use \n for LF and \r\n for CRLF.
   "files.eol": "\n",
   "files.insertFinalNewline": true,
   "files.trimFinalNewlines": true,
-  "files.trimTrailingWhitespace": false,
+  "files.trimTrailingWhitespace": true,
   "files.exclude": {
     "node_modules": true,
-    "out": true, // set this to true to hide the "out" folder with the compiled JS files
-    ".vscode-test": true
+    "out": true
   },
   "search.exclude": {
     "node_modules": true,
-    "out": true // set this to false to include "out" folder in search results
+    "out": true
+  },
+  "[javascript]": {
+    "editor.defaultFormatter": "esbenp.prettier-vscode"
+  },
+  "[json]": {
+    "editor.defaultFormatter": "esbenp.prettier-vscode",
+    "editor.quickSuggestions": {
+      "strings": true
+    },
+    "editor.suggest.insertMode": "replace"
+  },
+  "[jsonc]": {
+    "editor.defaultFormatter": "esbenp.prettier-vscode",
+    "editor.quickSuggestions": {
+      "strings": true
+    },
+    "editor.suggest.insertMode": "replace"
   },
-
-  // Turn off tsc task auto detection since we have the necessary tasks as npm scripts
   "typescript.tsc.autoDetect": "off",
   "typescript.format.enable": false,
   "[typescript]": {
-    "editor.formatOnSave": true,
-    "editor.formatOnType": true,
+    "editor.codeActionsOnSave": {
+      "source.fixAll": true,
+      "source.organizeImports": true
+    },
     "editor.defaultFormatter": "esbenp.prettier-vscode"
+  },
+  "eslint.enable": true,
+  "eslint.lintTask.enable": true,
+  "eslint.alwaysShowStatus": true,
+  "eslint.codeActionsOnSave.mode": "all",
+  "eslint.run": "onType",
+  "puppet.trace.server": {
+    "verbosity": "verbose",
+    "format": "json"
   }
 }