(GH-459) Consolidate debug features into a single feature

Previously there were two debug features, one for the factory and one
for the configuration.  This commit moves the functionality of the
DebugConfiguration into the DebuggingFeature.

Author: glennsarti

src/extension.ts

@@ -9,7 +9,6 @@ import { StdioConnectionHandler } from './handlers/stdio';
 import { TcpConnectionHandler } from './handlers/tcp';
 import { IFeature } from './feature';
 import { DebuggingFeature } from './feature/DebuggingFeature';
-import { DebugConfigurationFeature } from './feature/DebugConfigurationFeature';
 import { FormatDocumentFeature } from './feature/FormatDocumentFeature';
 import { NodeGraphFeature } from './feature/NodeGraphFeature';
 import { PDKFeature } from './feature/PDKFeature';
@@ -70,7 +69,6 @@ export function activate(context: vscode.ExtensionContext) {
   }
 
   extensionFeatures = [
-    new DebugConfigurationFeature(logger, extContext),
     new FormatDocumentFeature(puppetLangID, connectionHandler, settings, logger, extContext),
     new NodeGraphFeature(puppetLangID, connectionHandler, logger, extContext),
     new PDKFeature(extContext, logger),

src/feature/DebugConfigurationFeature.ts

@@ -94,8 +94,50 @@ export class DebugAdapterDescriptorFactory implements vscode.DebugAdapterDescrip
   }
 }
 
+export class DebugConfigurationProvider implements vscode.DebugConfigurationProvider {
+  private debugType: string;
+  private logger: ILogger;
+  private context: vscode.ExtensionContext;
+
+  constructor(debugType:string, logger: ILogger, context: vscode.ExtensionContext) {
+    this.debugType = debugType;
+    this.logger = logger;
+    this.context = context;
+  }
+
+  public provideDebugConfigurations(
+    folder: vscode.WorkspaceFolder | undefined,
+    token?: vscode.CancellationToken
+  ): vscode.ProviderResult<vscode.DebugConfiguration[]> {
+    return [ this.createLaunchConfigFromContext(folder) ];
+  }
+
+  public resolveDebugConfiguration(
+    folder: vscode.WorkspaceFolder | undefined,
+    debugConfiguration: vscode.DebugConfiguration,
+    token?: vscode.CancellationToken
+  ): vscode.ProviderResult<vscode.DebugConfiguration> {
+    return debugConfiguration;
+  }
+
+  private createLaunchConfigFromContext(folder: vscode.WorkspaceFolder | undefined): vscode.DebugConfiguration {
+    let config = {
+      type: this.debugType,
+      request: 'launch',
+      name: 'Puppet Apply current file',
+      manifest: "${file}",
+      args: [],
+      noop: true,
+      cwd: "${file}",
+    };
+
+    return config;
+  }
+}
+
 export class DebuggingFeature implements IFeature {
   private factory: DebugAdapterDescriptorFactory;
+  private provider: DebugConfigurationProvider;
 
   constructor(
     debugType: string,
@@ -105,9 +147,13 @@ export class DebuggingFeature implements IFeature {
     logger: ILogger
   ) {
     this.factory = new DebugAdapterDescriptorFactory(context, settings, config, logger);
+    this.provider = new DebugConfigurationProvider(debugType, logger, context);
 
     logger.debug("Registered DebugAdapterDescriptorFactory for " + debugType);
     context.subscriptions.push(vscode.debug.registerDebugAdapterDescriptorFactory(debugType, this.factory));
+
+    context.subscriptions.push(vscode.debug.registerDebugConfigurationProvider(debugType, this.provider));
+    logger.debug("Registered DebugConfigurationProvider for " + debugType);
   }
 
   public dispose(): any {