(GH-245) Add tests for document validation with CRLF

This commit adds a test and test fixture to ensure that the document validator
returns the same linting errors regardless of CRLF or LF line endings.

Author: glennsarti

server/spec/languageserver/fixtures/manifest_with_lint_errors.pp

@@ -0,0 +1,50 @@
+#
+class example_manifest_with_multiple_lint_errors
+{
+
+  # --------------------------------------------------------------------
+  # Set cipher suites order as secure as possible (Enables Perfect Forward Secrecy)
+  # Remediation list per CIS IIS 8 Benchmark v1.4.0 - 08-24-2015 (minus 3DES)
+  # Removed DHE per ITSec on 4/6/16
+  # TLS_DHE_RSA_WITH_AES_256_GCM_SHA384 and TLS_DHE_RSA_WITH_AES_128_GCM_SHA256
+  # --------------------------------------------------------------------
+  $cipherSuitesOrder = "TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256, \
+                        TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256, \
+                        TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P256, \
+                        TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA_P256, \
+                        TLS_ECDHE_ECDSA_WITH_AES_256_GCM_SHA384_P384, \
+                        TLS_ECDHE_ECDSA_WITH_AES_128_GCM_SHA256_P256"
+
+  registry::value { 'Cipher Suites':
+    key   => 'HKLM\\SOFTWARE\\Policies\\Microsoft\\Cryptography\\Configuration\\SSL\\00010002',
+    type  => string,
+    value => 'Functions',
+    data  => $cipherSuitesOrder,
+  }
+
+   # --------------------------------------------------------------------
+  # Disable IP Source Routing - Microsoft Security Bulletin MS06-032
+  # --------------------------------------------------------------------
+  registry::value { 'DisableIPSourceRouting0':
+    key   => 'HKLM\\System\\CurrentControlSet\\Services\\Tcpip\\Parameters',
+    type  => 'dword',
+    value => 'DisableIPSourceRouting',
+    data  => 2,
+  }
+
+  # --------------------------------------------------------------------
+  # Disable IPv6 Source Routing - Microsoft Security Bulletin MS06-032
+  # --------------------------------------------------------------------
+  registry_value { 'HKLM\System\CurrentControlSet\Services\Tcpip6\Parameters\DisableIPSourceRouting':
+    ensure => present,
+  	type   => dword,
+    data   => 2,
+    notify => Reboot['after_run'],
+  }
+
+  #Reboot Computer
+  reboot { 'after_run':
+    apply => finished,
+  }
+
+}

server/spec/languageserver/integration/puppet-languageserver/document_validator_spec.rb

@@ -146,6 +146,18 @@
       end
     end
 
+    describe "Given a complete manifest with linting errors" do
+      let(:manifest_fixture) { File.join($fixtures_dir,'manifest_with_lint_errors.pp') }
+      let(:manifest_lf) { File.open(manifest_fixture, 'r') { |file| file.read } }
+      let(:manifest_crlf) { File.open(manifest_fixture, 'r') { |file| file.read }.gsub("\n","\r\n") }
+
+      it "should return same errors for both LF and CRLF line endings" do
+        lint_error_lf = subject.validate(manifest_lf, nil)
+        lint_error_crlf = subject.validate(manifest_crlf, nil)
+        expect(lint_error_crlf).to eq(lint_error_lf)
+      end
+   end
+
     describe "Given a complete manifest with a single linting error" do
       let(:manifest) { "
         user { 'Bob':

server/spec/languageserver/spec_helper.rb

@@ -7,13 +7,13 @@
 $LOAD_PATH.unshift(File.join(root,'vendor','puppet-lint','lib'))
 
 require 'puppet-languageserver'
-fixtures_dir = File.join(File.dirname(__FILE__),'fixtures')
+$fixtures_dir = File.join(File.dirname(__FILE__),'fixtures')
 
 # Currently there is no way to re-initialize the puppet loader so for the moment
 # all tests must run off the single puppet config settings instead of per example setting
 server_options = PuppetLanguageServer::CommandLineParser.parse([])
-server_options[:puppet_settings] = ['--vardir',File.join(fixtures_dir,'cache'),
-                                    '--confdir',File.join(fixtures_dir,'confdir')]
+server_options[:puppet_settings] = ['--vardir',File.join($fixtures_dir,'cache'),
+                                    '--confdir',File.join($fixtures_dir,'confdir')]
 PuppetLanguageServer::init_puppet(server_options)
 
 def wait_for_puppet_loading