Skip to content

Commit 98dbaaf

Browse files
authored
Merge pull request #139 from jpogran/update-telemetry-to-prod
(GH-138) Update telemetry to prod
2 parents 26d468a + 6bbb578 commit 98dbaaf

File tree

8 files changed

+18
-19
lines changed

8 files changed

+18
-19
lines changed

client/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
"publisher": "jpogran",
77
"license": "SEE LICENSE IN LICENSE.txt",
88
"icon": "images/Puppet-Logo-Amber-sm.png",
9-
"aiKey": "ceeced67-dfaf-4693-a31f-640fd740bb15",
9+
"aiKey": "147f322c-ecdc-4db2-a818-da8be01f07f5",
1010
"galleryBanner": {
1111
"color": "#000000",
1212
"theme": "dark"

client/src/commands/pdk/pdkNewClassCommand.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -26,9 +26,7 @@ export class pdkNewClassCommand {
2626
this.terminal.sendText(`pdk new class ${moduleName}`);
2727
this.terminal.show();
2828
if (reporter) {
29-
reporter.sendTelemetryEvent('command', {
30-
command: messages.PDKCommandStrings.PdkNewClassCommandId
31-
});
29+
reporter.sendTelemetryEvent(messages.PDKCommandStrings.PdkNewClassCommandId);
3230
}
3331
})
3432
}

client/src/commands/pdk/pdkNewModuleCommand.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,9 +36,7 @@ export class pdkNewModuleCommand {
3636
this.terminal.sendText(`code ${dir}`)
3737
this.terminal.show();
3838
if (reporter) {
39-
reporter.sendTelemetryEvent('command', {
40-
command: messages.PDKCommandStrings.PdkNewModuleCommandId
41-
});
39+
reporter.sendTelemetryEvent(messages.PDKCommandStrings.PdkNewModuleCommandId);
4240
}
4341
})
4442
})

client/src/commands/pdk/pdkTestCommand.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,7 @@ export class pdkTestUnitCommand {
2020
this.terminal.sendText(`pdk test unit`);
2121
this.terminal.show();
2222
if (reporter) {
23-
reporter.sendTelemetryEvent('command', {
24-
command: messages.PDKCommandStrings.PdkTestUnitCommandId
25-
});
23+
reporter.sendTelemetryEvent(messages.PDKCommandStrings.PdkTestUnitCommandId);
2624
}
2725
}
2826

client/src/commands/pdk/pdkValidateCommand.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,7 @@ export class pdkValidateCommand {
2020
this.terminal.sendText(`pdk validate`);
2121
this.terminal.show();
2222
if (reporter) {
23-
reporter.sendTelemetryEvent('command', {
24-
command: messages.PDKCommandStrings.PdkValidateCommandId
25-
});
23+
reporter.sendTelemetryEvent(messages.PDKCommandStrings.PdkValidateCommandId);
2624
}
2725
}
2826

client/src/commands/puppet/puppetResourceCommand.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -65,9 +65,7 @@ export class puppetResourceCommand {
6565

6666
this.editCurrentDocument(doc.uri, resourceResult.data, newPosition);
6767
if (reporter) {
68-
reporter.sendTelemetryEvent('command', {
69-
command: messages.PuppetCommandStrings.PuppetResourceCommandId
70-
});
68+
reporter.sendTelemetryEvent(messages.PuppetCommandStrings.PuppetResourceCommandId);
7169
}
7270
});
7371
}

client/src/connection.ts

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ import { Logger } from '../src/logging';
66
import { LanguageClient, LanguageClientOptions, ServerOptions } from 'vscode-languageclient';
77
import { setupPuppetCommands } from '../src/commands/puppetcommands';
88
import { setupPDKCommands } from '../src/commands/pdkcommands';
9+
import { reporter } from './telemetry/telemetry';
910
import * as messages from '../src/messages';
1011
import fs = require('fs');
1112

@@ -326,6 +327,16 @@ export class ConnectionManager implements IConnectionManager {
326327
langClient.logger.debug('Language server client started, setting puppet version')
327328
languageServerClient.sendRequest(messages.PuppetVersionRequest.type).then((versionDetails) => {
328329
this.setConnectionStatus(versionDetails.puppetVersion, ConnectionStatus.Running);
330+
if (reporter) {
331+
reporter.sendTelemetryEvent('puppetVersion' +versionDetails.puppetVersion);
332+
reporter.sendTelemetryEvent('facterVersion' + versionDetails.facterVersion);
333+
reporter.sendTelemetryEvent('languageServerVersion' + versionDetails.languageServerVersion);
334+
reporter.sendTelemetryEvent('version', {
335+
puppetVersion: versionDetails.puppetVersion,
336+
facterVersion: versionDetails.facterVersion,
337+
languageServerVersion: versionDetails.languageServerVersion,
338+
});
339+
}
329340
});
330341
}, (reason) => {
331342
this.setSessionFailure("Could not start language service: ", reason);

client/src/providers/previewNodeGraphProvider.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -82,9 +82,7 @@ export class PuppetNodeGraphContentProvider implements vscode.TextDocumentConten
8282
var errorContent = `<div>${compileResult.error}</div>`
8383
if (compileResult.error == null) { errorContent = ''; }
8484
if (reporter) {
85-
reporter.sendTelemetryEvent('command', {
86-
command: messages.PuppetCommandStrings.PuppetNodeGraphToTheSideCommandId
87-
});
85+
reporter.sendTelemetryEvent(messages.PuppetCommandStrings.PuppetNodeGraphToTheSideCommandId);
8886
}
8987

9088
// WARNING - THIS IS A MAJOR HACK!!!

0 commit comments

Comments
 (0)