(GH-100) Refactor the Extension for common simple interfaces

The Debug Adapter requires similar object and configuration options from the
extension.  This commit refactors out the simple interfaces (i.e. cannot include
complex types, particularly from the vscode namespace) so that it can be
consumed by an out-of-process DebugAdapter.

Author: glennsarti

client/src/commands/puppet/puppetResourceCommand.ts

@@ -1,7 +1,8 @@
 'use strict';
 
 import * as vscode from 'vscode';
-import { IConnectionManager, ConnectionStatus } from '../../connection';
+import { ConnectionStatus } from '../../interfaces';
+import { IConnectionManager } from '../../connection';
 import { ILogger } from '../../logging';
 import { reporter } from '../../telemetry/telemetry';
 import * as messages from '../../messages';

client/src/configuration.ts

@@ -2,7 +2,8 @@
 
 import * as vscode from 'vscode';
 
-import { ConnectionManager, IConnectionConfiguration, ConnectionType } from './connection';
+import { IConnectionConfiguration, ConnectionType } from './interfaces';
+import { ConnectionManager } from './connection';
 
 export class ConnectionConfiguration implements IConnectionConfiguration {
   public type: ConnectionType = ConnectionType.Unknown; 

client/src/connection.ts

@@ -3,6 +3,7 @@ import path = require('path');
 import vscode = require('vscode');
 import cp = require('child_process');
 import { ILogger } from '../src/logging';
+import { IConnectionConfiguration, ConnectionStatus, ConnectionType } from './interfaces'
 import { LanguageClient, LanguageClientOptions, ServerOptions } from 'vscode-languageclient';
 import { ConnectionConfiguration } from './configuration';
 import { setupPuppetCommands } from '../src/commands/puppetcommands';
@@ -13,30 +14,6 @@ import fs = require('fs');
 
 const langID = 'puppet'; // don't change this
 
-export enum ConnectionStatus {
-  NotStarted,
-  Starting,
-  Running,
-  Stopping,
-  Failed
-}
-
-export enum ConnectionType {
-  Unknown,
-  Local,
-  Remote
-}
-
-export interface IConnectionConfiguration {
-  type: ConnectionType;
-  host: string;
-  port: number;
-  timeout: number;
-  preLoadPuppet: boolean;
-  debugFilePath: string;
-  puppetAgentDir: string;
-}
-
 export interface IConnectionManager {
   status: ConnectionStatus;
   languageClient: LanguageClient;

client/src/extension.ts

@@ -3,7 +3,8 @@
 import * as vscode from 'vscode';
 import * as path from 'path';
 
-import { ConnectionManager, IConnectionConfiguration, ConnectionType } from './connection';
+import { IConnectionConfiguration, ConnectionType } from './interfaces';
+import { ConnectionManager } from './connection';
 import { ConnectionConfiguration } from './configuration';
 import { ILogger } from './logging';
 import { OutputChannelLogger } from './logging/outputchannel';

client/src/interfaces.ts

@@ -0,0 +1,27 @@
+'use strict';
+
+// Only add simple interfaces here. No import's allowed
+
+export enum ConnectionStatus {
+  NotStarted,
+  Starting,
+  Running,
+  Stopping,
+  Failed
+}
+
+export enum ConnectionType {
+  Unknown,
+  Local,
+  Remote
+}
+
+export interface IConnectionConfiguration {
+  type: ConnectionType;
+  host: string;
+  port: number;
+  timeout: number;
+  preLoadPuppet: boolean;
+  debugFilePath: string;
+  puppetAgentDir: string;
+}

client/src/providers/previewNodeGraphProvider.ts

@@ -3,7 +3,8 @@
 import * as vscode from 'vscode';
 import * as path from 'path';
 import { CompileNodeGraphRequest } from '../messages';
-import { IConnectionManager, ConnectionStatus } from '../connection';
+import { ConnectionStatus } from '../interfaces';
+import { IConnectionManager } from '../connection';
 import { reporter } from '../telemetry/telemetry';
 import * as messages from '../messages';
 import * as viz from 'viz.js';