Merge pull request #503 from albatrossflavour/feature/change_default_install_type

(GH-502) change the default install type to PDK

Author: jpogran

package.json

@@ -402,7 +402,7 @@
         },
         "puppet.installType": {
           "type": "string",
-          "default": "agent",
+          "default": "pdk",
           "description": "The type of Puppet installation. Either the Puppet Development Kit (pdk) or the Puppet Agent (agent)",
           "enum": [
             "pdk",

src/settings.ts

@@ -163,7 +163,7 @@ export function DefaultWorkspaceSettings(): ISettings {
       enable: true
     },
     installDirectory: undefined,
-    installType: PuppetInstallType.PUPPET,
+    installType: PuppetInstallType.PDK,
     lint: {
       enable: true,
     },

src/test/configuration.test.ts

@@ -21,10 +21,10 @@ suite("Configuration Tests", () => {
       break;
   }
 
-  test("resolves puppetBaseDir as puppet with default installtype", () => {
+  test("resolves pdkPuppetBaseDir as puppet with default installtype", () => {
     const settings: ISettings = DefaultWorkspaceSettings();
     var config = CreateAggregrateConfiguration(settings);
-    assert.equal(config.ruby.puppetBaseDir, puppetBaseDir);
+    assert.equal(config.ruby.puppetBaseDir, pdkPuppetBaseDir);
   });
 
   test("resolves puppetBaseDir as puppet with installtype eq puppet", () => {