(GH-459) Remove legacy debug adapter code

Now that the puppetAdapterExecutableCommand has been removed, all of the code
required to implement the command is no longer required.  This commit removes this
code and any upstream dependencies.

This commit also removes the Debug Adapter and dependant code as the new API
makes this redundant.  All of the ruby detection can now use the same file
whereas previously it had to be split up due to different node environments.

Author: glennsarti

src/debugAdapter.ts

@@ -16,7 +16,6 @@ import { PuppetResourceFeature } from './feature/PuppetResourceFeature';
 import { ProtocolType, ConnectionType, IConnectionConfiguration } from './interfaces';
 import { ILogger } from './logging';
 import { OutputChannelLogger } from './logging/outputchannel';
-import { PuppetCommandStrings } from './messages';
 import { PuppetStatusBar } from './PuppetStatusBar';
 import { ISettings, legacySettings, settingsFromWorkspace } from './settings';
 import { Reporter, reporter } from './telemetry/telemetry';

src/extension.ts

@@ -5,11 +5,6 @@ import * as path from 'path';
 
 import { IFeature } from "../feature";
 import { ILogger } from "../logging";
-import { IConnectionConfiguration } from '../interfaces';
-import { ConnectionConfiguration } from "../configuration";
-import { RubyHelper } from "../rubyHelper";
-
-const PuppetAdapterExecutableCommandId = 'extension.puppetAdapterExecutableCommand';
 
 export class DebugConfigurationProvider implements vscode.DebugConfigurationProvider {
   private debugType: string;
@@ -37,35 +32,6 @@ export class DebugConfigurationProvider implements vscode.DebugConfigurationProv
     return debugConfiguration;
   }
 
-  public puppetAdapterExecutableCommand(context: vscode.ExtensionContext) {
-    const config: IConnectionConfiguration = new ConnectionConfiguration();
-    const rubyConfig = RubyHelper.getRubyEnvFromConfiguration('', config, this.logger);
-
-    const debugAdapterPath = path.join(this.context.extensionPath, 'out', 'debugAdapter.js');
-    const debugServerPath = path.join(__dirname,'..','..','vendor', 'languageserver', 'puppet-debugserver');
-    let args = [];
-
-    args.push(debugAdapterPath);
-    // Add path the ruby executable
-    args.push(`\"RUBY=${rubyConfig.command}\"`);
-    // Add path to the Debug Server file
-    args.push(`\"RUBYFILE=${debugServerPath}\"`);
-    // // Add additional environment variables
-    const currentEnv = process.env;
-    for (const key in rubyConfig.options.env) {
-      const value = rubyConfig.options.env[key];
-      if (!currentEnv[key] || (currentEnv[key] !== value)) {
-        args.push(`\"ENV=${key}=${value}\"`);
-      }
-    }
-    // TODO: Add additional command line args e.g. --debuglogfie
-
-    return {
-      command: 'node',
-      args: args
-    };
-  }
-
   private createLaunchConfigFromContext(folder: vscode.WorkspaceFolder | undefined): vscode.DebugConfiguration {
     let config = {
       type: this.debugType,
@@ -89,8 +55,6 @@ export class DebugConfigurationFeature implements IFeature {
     this.provider = new DebugConfigurationProvider(this.debugType, logger, context);
     context.subscriptions.push(vscode.debug.registerDebugConfigurationProvider(this.debugType, this.provider));
     logger.debug("Registered DebugConfigurationProvider");
-    context.subscriptions.push(vscode.commands.registerCommand(PuppetAdapterExecutableCommandId, () => this.provider.puppetAdapterExecutableCommand(context)));
-    logger.debug("Registered " + PuppetAdapterExecutableCommandId + " command");
   }
 
   public dispose(): any { return undefined; }

src/feature/DebugConfigurationFeature.ts

@@ -1,5 +1,4 @@
 import * as vscode from 'vscode';
-import * as path from 'path';
 
 import { ServerOptions, Executable } from 'vscode-languageclient';
 import { ConnectionHandler } from '../handler';

src/handlers/stdio.ts

@@ -1,13 +1,5 @@
 'use strict';
 
-// Only add simple interfaces here. No import's allowed
-
-// Only add simple interfaces here. No import's allowed
-// Only add simple interfaces here. No import's allowed
-// Only add simple interfaces here. No import's allowed
-// Only add simple interfaces here. No import's allowed
-// Only add simple interfaces here. No import's allowed
-// Only add simple interfaces here. No import's allowed
 // Only add simple interfaces here. No import's allowed
 export enum ConnectionStatus {
   NotStarted,
@@ -36,10 +28,6 @@ export enum ProtocolType {
 export interface IConnectionConfiguration {
   type: ConnectionType;
   protocol: ProtocolType;
-  host: string;
-  port: number;
-  timeout: number;
-  debugFilePath: string;
   puppetBaseDir: string;
   puppetDir: string;
   languageServerPath: string;
@@ -48,9 +36,7 @@ export interface IConnectionConfiguration {
   environmentPath: string;
   sslCertFile: string;
   sslCertDir: string;
-  languageServerCommandLine: Array<string>;
 
-  puppetInstallType:PuppetInstallType; 
   pdkBinDir:string;
   pdkRubyLib:string;
   pdkRubyVerDir:string;