Skip to content

Commit c04dd84

Browse files
committed
(GH-412) Strongly type ProtocolType in settings
This changes the settings to strongly type `ProtocolType` instead of using `string` and forcing downstream code to parse it correctly. It instead is cast when settings is used, and this does not fail because it is a typed array inside package.json.
1 parent 509bf5a commit c04dd84

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/settings.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ export interface IEditorServiceSettings {
1818
enable?: boolean;
1919
featureflags?: string[];
2020
loglevel?: string;
21-
protocol?: string;
21+
protocol?: ProtocolType;
2222
tcp?: IEditorServiceTCPSettings;
2323
timeout?: number;
2424
}

0 commit comments

Comments
 (0)