Skip to content

Commit c3ddc5a

Browse files
fix: use github.run_number for BUILD_VERSION in nightly workflow
Resolves npm version error in scheduled runs where github.event.number is undefined, causing invalid version string "0.99." Signed-off-by: Gavin Didrichsen <[email protected]>
1 parent 34b1c8f commit c3ddc5a

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

.github/workflows/nightly.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ jobs:
6262
6363
- name: npm test
6464
env:
65-
BUILD_VERSION: '0.99.${{ github.event.number }}'
65+
BUILD_VERSION: 0.99.${{ github.run_number }}
6666
VSCODE_BUILD_VERBOSE: true
6767
DISPLAY: ':99.0'
6868
shell: pwsh
@@ -72,7 +72,7 @@ jobs:
7272
- name: vsce package
7373
if: runner.os == 'Linux'
7474
env:
75-
BUILD_VERSION: '0.99.${{ github.event.number }}'
75+
BUILD_VERSION: 0.99.${{ github.run_number }}
7676
shell: pwsh
7777
run: |
7878
invoke-psake -properties @{ packageVersion = $env:BUILD_VERSION } -tasklist bump

0 commit comments

Comments
 (0)