(GH-439) Remove RestartSession Command

Removes the RestartSession Command from the extension. During the
refactor in #425 the
ability to restart the session using a command was not retained. After
the refactor it was clear that way it was architected that it would not
allow the restart to work. Considering the 'Reload Window' workflow is
more familiar to users, it was decided to remove it and instead guide
users to reloading the window to restart the extension since state is
kept during a reload.

Author: jpogran

README.md

@@ -361,9 +361,7 @@ If you are receiving an error right after opening a Puppet file saying that a Pu
 
 If you haven't see the Problems Pane update in awhile, or hover and intellisense doesn't seem to showing up, and you might not know what to do. Sometimes the Puppet extension can experience problems which cause the language server to crash or not respond. The extension has a way of logging the crash, but there is something you can do to get right back to working: reload the Puppet Language Server.
 
-You can reload the Puppet Lanuguage Server by opening the command palette and starting to type `Puppet`. A list of Puppet commands will appear, select `Puppet: Restart Current Session`. This will restart the Puppet Language Server without reloading VSCode or losing any work currently open in the editor.
-
-![Reload Puppet Language Server](https://raw.githubusercontent.com/lingua-pupuli/puppet-vscode/master/docs/assets/reload_language_server.gif)
+You can reload the Puppet Lanuguage Server by opening the command palette and starting to type `Reload`. A list of commands will appear, select `Reload Window`. This will reload the Visual Studio Code window without closing down the enitre edtior, and without losing any work currently open in the editor.
 
 ## Reporting Problems
 

docs/assets/reload_language_server.gif

@@ -39,7 +39,6 @@
   ],
   "activationEvents": [
     "onLanguage:puppet",
-    "onCommand:extension.puppetRestartSession",
     "onCommand:extension.puppetShowConnectionLogs",
     "onCommand:extension.puppetShowConnectionMenu",
     "onCommand:extension.puppetLint",
@@ -96,11 +95,6 @@
       }
     ],
     "commands": [
-      {
-        "command": "extension.puppetRestartSession",
-        "category": "Puppet",
-        "title": "Restart Current Session"
-      },
       {
         "command": "extension.puppetShowConnectionLogs",
         "category": "Puppet",
@@ -152,9 +146,6 @@
     ],
     "menus": {
       "commandPalette": [
-        {
-          "command": "extension.puppetRestartSession"
-        },
         {
           "command": "extension.puppetShowConnectionLogs"
         },

package.json

@@ -66,13 +66,7 @@ export class PuppetStatusBar {
 
   public static showConnectionMenu() {
     var menuItems: PuppetConnectionMenuItem[] = [];
-  
-    menuItems.push(
-      new PuppetConnectionMenuItem(
-        "Restart Current Puppet Session",
-        () => { vscode.commands.executeCommand(PuppetCommandStrings.PuppetRestartSessionCommandId); }),
-    );
-  
+
     menuItems.push(
       new PuppetConnectionMenuItem(
         "Show Puppet Session Logs",

src/PuppetStatusBar.ts

@@ -67,12 +67,6 @@ export function activate(context: vscode.ExtensionContext) {
     new PDKFeature(extContext, logger),
     new PuppetResourceFeature(extContext, connectionHandler, logger)
   ];
-
-  extContext.subscriptions.push(vscode.commands.registerCommand(PuppetCommandStrings.PuppetRestartSessionCommandId,
-    () => {
-      
-    }
-  ));
 }
 
 export function deactivate() {

src/extension.ts

@@ -61,7 +61,6 @@ export class PuppetCommandStrings {
   static PuppetResourceCommandId: string = 'extension.puppetResource';
   static PuppetShowConnectionMenuCommandId = 'extension.puppetShowConnectionMenu';
   static PuppetShowConnectionLogsCommandId = 'extension.puppetShowConnectionLogs';
-  static PuppetRestartSessionCommandId = 'extension.puppetRestartSession';
 }
 
 export class PDKCommandStrings {