(PUP-11993) Style/StringLiteralsInInterpolation

This commit enables the Style/StringLiteralsInInterpolation cop and
fixes 23 autocorrectable offenses.

Author: AriaXLi

.rubocop_todo.yml

@@ -722,12 +722,6 @@ Style/StringConcatenation:
 Style/StringLiterals:
   Enabled: false
 
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: single_quotes, double_quotes
-Style/StringLiteralsInInterpolation:
-  Enabled: false
-
 # This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: EnforcedStyle, MinSize.
 # SupportedStyles: percent, brackets

lib/puppet/confine/variable.rb

@@ -29,7 +29,7 @@ def initialize(values)
   end
 
   def message(value)
-    "facter value '#{test_value}' for '#{name}' not in required list '#{values.join(",")}'"
+    "facter value '#{test_value}' for '#{name}' not in required list '#{values.join(',')}'"
   end
 
   # Compare the passed-in value to the retrieved value.

lib/puppet/interface/action.rb

@@ -254,7 +254,7 @@ def when_invoked=(block)
     file    = __FILE__ + "+eval[wrapper]"
     line    = __LINE__ + 2 # <== points to the same line as 'def' in the wrapper.
     wrapper = <<~WRAPPER
-      def #{@name}(#{decl.join(", ")})
+      def #{@name}(#{decl.join(', ')})
         #{optn}
         args    = #{args}
         action  = get_action(#{name.inspect})

lib/puppet/interface/action_manager.rb

@@ -80,7 +80,7 @@ def get_action(name)
   def get_default_action
     default = actions.map { |x| get_action(x) }.select { |x| x.default }
     if default.length > 1
-      raise "The actions #{default.map(&:name).join(", ")} cannot all be default"
+      raise "The actions #{default.map(&:name).join(', ')} cannot all be default"
     end
 
     default.first

lib/puppet/node/environment.rb

@@ -518,7 +518,7 @@ def to_s
 
   # @api public
   def inspect
-    %Q(<#{self.class}:#{object_id} @name="#{name}" @manifest="#{manifest}" @modulepath="#{full_modulepath.join(":")}" >)
+    %Q(<#{self.class}:#{object_id} @name="#{name}" @manifest="#{manifest}" @modulepath="#{full_modulepath.join(':')}" >)
   end
 
   # @return [Symbol] The `name` value, cast to a string, then cast to a symbol.

lib/puppet/parameter.rb

@@ -121,7 +121,7 @@ def doc
 
         features = required_features
         if features
-          @doc << "\n\nRequires features #{features.flatten.collect { |f| f.to_s }.join(" ")}."
+          @doc << "\n\nRequires features #{features.flatten.collect { |f| f.to_s }.join(' ')}."
         end
         @addeddocvals = true
       end

lib/puppet/parameter/value_collection.rb

@@ -37,15 +37,15 @@ def doc
         @doc << @strings.collect do |value|
           aliases = value.aliases
           if aliases && !aliases.empty?
-            "`#{value.name}` (also called `#{aliases.join(", ")}`)"
+            "`#{value.name}` (also called `#{aliases.join(', ')}`)"
           else
             "`#{value.name}`"
           end
         end.join(", ") << ". "
       end
 
       unless regexes.empty?
-        @doc << "Values can match `#{regexes.join("`, `")}`."
+        @doc << "Values can match `#{regexes.join('`, `')}`."
       end
     end
 

lib/puppet/parser/functions.rb

@@ -263,7 +263,7 @@ def self.functiondocs(environment = Puppet.lookup(:current_environment))
     ret = ''.dup
 
     merged_functions(environment).sort { |a, b| a[0].to_s <=> b[0].to_s }.each do |name, hash|
-      ret << "#{name}\n#{"-" * name.to_s.length}\n"
+      ret << "#{name}\n#{'-' * name.to_s.length}\n"
       if hash[:doc]
         ret << Puppet::Util::Docs.scrub(hash[:doc])
       else

lib/puppet/parser/templatewrapper.rb

@@ -100,6 +100,6 @@ def result(string = nil)
   end
 
   def to_s
-    "template[#{@__file__ || "inline"}]"
+    "template[#{@__file__ || 'inline'}]"
   end
 end

lib/puppet/pops/evaluator/runtime3_converter.rb

@@ -70,7 +70,7 @@ def convert_Integer(o, scope, undef_value)
     return o unless o < MIN_INTEGER || o > MAX_INTEGER
 
     range_end = o > MAX_INTEGER ? 'max' : 'min'
-    raise Puppet::Error, "Use of a Ruby Integer outside of Puppet Integer #{range_end} range, got '#{"0x%x" % o}'"
+    raise Puppet::Error, "Use of a Ruby Integer outside of Puppet Integer #{range_end} range, got '#{'0x%x' % o}'"
   end
 
   def convert_BigDecimal(o, scope, undef_value)