(PUP-11767) Enable Style/IfWithBooleanLiteralBranches

Author: tvpartytonight

.rubocop.yml

@@ -322,3 +322,6 @@ Style/IfInsideElse:
 
 Style/IfUnlessModifierOfIfUnless:
   Enabled: true
+
+Style/IfWithBooleanLiteralBranches:
+  Enabled: true

lib/puppet/defaults.rb

@@ -489,7 +489,7 @@ def self.initialize_default_settings!(settings)
     },
     :daemonize => {
         :type     => :boolean,
-        :default  => (Puppet::Util::Platform.windows? ? false : true),
+        :default  => (!Puppet::Util::Platform.windows?),
         :desc     => "Whether to send the process into the background.  This defaults
           to true on POSIX systems, and to false on Windows (where Puppet
           currently cannot daemonize).",

lib/puppet/type/exec.rb

@@ -415,11 +415,7 @@ def value=(*values)
       # on refresh.
       def check(value)
         # We have to invert the values.
-        if value == :true
-          false
-        else
-          true
-        end
+        value != :true
       end
     end
 

lib/puppet/type/file.rb

@@ -874,7 +874,7 @@ def should_be_file?
     if self[:ensure] == :present
       return true unless stat
 
-      return(stat.ftype == "file" ? true : false)
+      return(stat.ftype == "file")
     end
 
     # If we've gotten here, then :ensure isn't set
@@ -1023,11 +1023,8 @@ def can_backup?(type)
       # (#18110) Directories cannot be removed without :force,
       # so it doesn't make sense to back them up unless removing with :force.
       true
-    elsif type == "file" or type == "link"
-      true
     else
-      # Including: “blockSpecial”, “characterSpecial”, "fifo", "socket", “unknown”
-      false
+      type == "file" or type == "link"
     end
   end