Layout/MultilineMethodCallBraceLayout

This commit enables the Rubocop Layout/MultilineMethodCallBraceLayout
cop and addresses all offenses.

Author: mhashizume

.rubocop_todo.yml

@@ -22,12 +22,6 @@ I18n/GetText/DecorateStringFormattingUsingPercent:
 I18n/RailsI18n/DecorateString:
   Enabled: false
 
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: symmetrical, new_line, same_line
-Layout/MultilineMethodCallBraceLayout:
-  Enabled: false
-
 # This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: EnforcedStyle, IndentationWidth.
 # SupportedStyles: aligned, indented, indented_relative_to_receiver

lib/puppet.rb

@@ -227,7 +227,8 @@ def self.base_context(settings)
         loaders << Puppet::Environments::StaticPrivate.new(
           Puppet::Node::Environment.create(default_environment,
                                            modulepath,
-                                           Puppet::Node::Environment::NO_MANIFEST))
+                                           Puppet::Node::Environment::NO_MANIFEST)
+        )
       end
     end
 

lib/puppet/datatypes.rb

@@ -158,7 +158,8 @@ def create_type(loader)
 
       created_type = Puppet::Pops::Types::PObjectType.new(
         @type_name,
-        Puppet::Pops::Parser::EvaluatingParser.new.parse_string("{ #{@interface} }").body)
+        Puppet::Pops::Parser::EvaluatingParser.new.parse_string("{ #{@interface} }").body
+      )
 
       if !@implementation_class.nil?
         if @implementation_class < Puppet::Pops::Types::PuppetObject

lib/puppet/error.rb

@@ -105,7 +105,8 @@ def self.from_issue_and_stack(issue, args = {})
         nil,
         nil,
         issue.issue_code,
-        args)
+        args
+      )
     end
   end
 

lib/puppet/file_bucket/dipper.rb

@@ -70,7 +70,8 @@ def diff(checksum_a, checksum_b, file_a, file_b)
         file_diff = Puppet::FileBucket::File.indirection.find(
           source_path,
           :bucket_path => @local_path,
-          :diff_with => checksum_b)
+          :diff_with => checksum_b
+        )
       elsif file_b
         tmp_file = ::Tempfile.new('diff')
         begin
@@ -167,7 +168,8 @@ def list(fromdate, todate)
       :bucket_path => @local_path,
       :list_all => true,
       :fromdate => fromdate,
-      :todate => todate)
+      :todate => todate
+    )
     raise Puppet::Error, _("File not found") unless file_bucket_list
 
     file_bucket_list.to_s

lib/puppet/functions/assert_type.rb

@@ -79,7 +79,8 @@ def assert_type(type, value)
       else
         raise Puppet::Pops::Types::TypeAssertionError.new(
           Puppet::Pops::Types::TypeMismatchDescriber.singleton.describe_mismatch('assert_type():', type, inferred_type),
-          type, inferred_type)
+          type, inferred_type
+        )
       end
     end
     value

lib/puppet/functions/contain.rb

@@ -34,7 +34,8 @@ def contain(scope, *classes)
     if Puppet[:tasks]
       raise Puppet::ParseErrorWithIssue.from_issue_and_stack(
         Puppet::Pops::Issues::CATALOG_OPERATION_NOT_SUPPORTED_WHEN_SCRIPTING,
-        {:operation => 'contain'})
+        {:operation => 'contain'}
+      )
     end
 
     # Make call patterns uniform and protected against nested arrays, also make

lib/puppet/functions/include.rb

@@ -42,7 +42,8 @@ def include(scope, *classes)
     if Puppet[:tasks]
       raise Puppet::ParseErrorWithIssue.from_issue_and_stack(
         Puppet::Pops::Issues::CATALOG_OPERATION_NOT_SUPPORTED_WHEN_SCRIPTING,
-        {:operation => 'include'})
+        {:operation => 'include'}
+      )
     end
 
     classes = scope.transform_and_assert_classnames(classes.flatten)

lib/puppet/functions/require.rb

@@ -50,7 +50,8 @@ def require_impl(scope, *classes)
     if Puppet[:tasks]
       raise Puppet::ParseErrorWithIssue.from_issue_and_stack(
         Puppet::Pops::Issues::CATALOG_OPERATION_NOT_SUPPORTED_WHEN_SCRIPTING,
-        {:operation => 'require'})
+        {:operation => 'require'}
+      )
     end
 
     # Make call patterns uniform and protected against nested arrays, also make

lib/puppet/http/service.rb

@@ -121,8 +121,7 @@ def add_puppet_headers(headers)
   def build_url(api, server, port)
     URI::HTTPS.build(host: server,
                      port: port,
-                     path: api
-                    ).freeze
+                     path: api).freeze
   end
 
   def get_mime_types(model)