(PUP-11993) Style/RaiseArgs

This commit enables the Style/RaiseArgs cop and fixes 253
autocorrectable offenses.

Author: AriaXLi

.rubocop_todo.yml

@@ -646,12 +646,6 @@ Style/OptionalBooleanParameter:
 Style/PreferredHashMethods:
   Enabled: false
 
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: EnforcedStyle, AllowedCompactTypes.
-# SupportedStyles: compact, exploded
-Style/RaiseArgs:
-  Enabled: false
-
 # This cop supports safe auto-correction (--auto-correct).
 Style/RedundantAssignment:
   Exclude:

lib/puppet/application.rb

@@ -251,7 +251,7 @@ def find(application_name)
       ################################################################
 
       if clazz.nil?
-        raise Puppet::Error.new(_("Unable to load application class '%{class_name}' from file 'puppet/application/%{application_name}.rb'") % { class_name: class_name, application_name: application_name })
+        raise Puppet::Error, _("Unable to load application class '%{class_name}' from file 'puppet/application/%{application_name}.rb'") % { class_name: class_name, application_name: application_name }
       end
 
       return clazz

lib/puppet/application/face_base.rb

@@ -105,7 +105,7 @@ def parse_options
             if option
               index += 1 if option[:argument] and !(option[:optional])
             else
-              raise OptionParser::InvalidOption.new(item.sub(/=.*$/, ''))
+              raise OptionParser::InvalidOption, item.sub(/=.*$/, '')
             end
           end
         end

lib/puppet/application/ssl.rb

@@ -192,7 +192,7 @@ def submit_request(ssl_context)
     Puppet.notice _("Submitted certificate request for '%{name}' to %{url}") % { name: Puppet[:certname], url: route.url }
   rescue Puppet::HTTP::ResponseError => e
     if e.response.code == 400
-      raise Puppet::Error.new(_("Could not submit certificate request for '%{name}' to %{url} due to a conflict on the server") % { name: Puppet[:certname], url: route.url })
+      raise Puppet::Error, _("Could not submit certificate request for '%{name}' to %{url} due to a conflict on the server") % { name: Puppet[:certname], url: route.url }
     else
       raise Puppet::Error.new(_("Failed to submit certificate request: %{message}") % { message: e.message }, e)
     end

lib/puppet/configurer.rb

@@ -536,7 +536,7 @@ def valid_server_environment?
     rescue Puppet::HTTP::ResponseError => detail
       if detail.response.code == 404
         if Puppet[:strict_environment_mode]
-          raise Puppet::Error.new(_("Environment '%{environment}' not found on server, aborting run.") % { environment: @environment })
+          raise Puppet::Error, _("Environment '%{environment}' not found on server, aborting run.") % { environment: @environment }
         else
           Puppet.notice(_("Environment '%{environment}' not found on server, skipping initial pluginsync.") % { environment: @environment })
         end

lib/puppet/configurer/downloader.rb

@@ -20,7 +20,7 @@ def evaluate
           if first_failure
             event = (first_failure.events || []).first
             detail = event ? event.message : 'unknown'
-            raise Puppet::Error.new(_("Failed to retrieve %{name}: %{detail}") % { name: name, detail: detail })
+            raise Puppet::Error, _("Failed to retrieve %{name}: %{detail}") % { name: name, detail: detail }
           end
         end
 

lib/puppet/file_bucket/file.rb

@@ -26,12 +26,12 @@ def initialize(contents, options = {})
     when Pathname
       @contents = FileContents.new(contents)
     else
-      raise ArgumentError.new(_("contents must be a String or Pathname, got a %{contents_class}") % { contents_class: contents.class })
+      raise ArgumentError, _("contents must be a String or Pathname, got a %{contents_class}") % { contents_class: contents.class }
     end
 
     @bucket_path = options.delete(:bucket_path)
     @checksum_type = Puppet[:digest_algorithm].to_sym
-    raise ArgumentError.new(_("Unknown option(s): %{opts}") % { opts: options.keys.join(', ') }) unless options.empty?
+    raise ArgumentError, _("Unknown option(s): %{opts}") % { opts: options.keys.join(', ') } unless options.empty?
   end
 
   # @return [Num] The size of the contents

lib/puppet/file_serving/base.rb

@@ -59,7 +59,7 @@ def links=(value)
   attr_reader :path
 
   def path=(path)
-    raise ArgumentError.new(_("Paths must be fully qualified")) unless Puppet::FileServing::Base.absolute?(path)
+    raise ArgumentError, _("Paths must be fully qualified") unless Puppet::FileServing::Base.absolute?(path)
 
     @path = path
   end
@@ -69,7 +69,7 @@ def path=(path)
   attr_reader :relative_path
 
   def relative_path=(path)
-    raise ArgumentError.new(_("Relative paths must not be fully qualified")) if Puppet::FileServing::Base.absolute?(path)
+    raise ArgumentError, _("Relative paths must not be fully qualified") if Puppet::FileServing::Base.absolute?(path)
 
     @relative_path = path
   end

lib/puppet/file_serving/configuration/parser.rb

@@ -43,13 +43,13 @@ def parse
             end
           else
             error_location_str = Puppet::Util::Errors.error_location(@file.filename, @count)
-            raise ArgumentError.new(_("Invalid argument '%{var}' at %{error_location}") %
-                                        { var: var, error_location: error_location_str })
+            raise ArgumentError, _("Invalid argument '%{var}' at %{error_location}") %
+                                 { var: var, error_location: error_location_str }
           end
         else
           error_location_str = Puppet::Util::Errors.error_location(@file.filename, @count)
-          raise ArgumentError.new(_("Invalid entry at %{error_location}: '%{file_text}'") %
-                                      { file_text: line.chomp, error_location: error_location_str })
+          raise ArgumentError, _("Invalid entry at %{error_location}: '%{file_text}'") %
+                               { file_text: line.chomp, error_location: error_location_str }
         end
       end
     end
@@ -73,8 +73,8 @@ def changed?
   def newmount(name)
     if @mounts.include?(name)
       error_location_str = Puppet::Util::Errors.error_location(@file, @count)
-      raise ArgumentError.new(_("%{mount} is already mounted at %{name} at %{error_location}") %
-                                  { mount: @mounts[name], name: name, error_location: error_location_str })
+      raise ArgumentError, _("%{mount} is already mounted at %{name} at %{error_location}") %
+                           { mount: @mounts[name], name: name, error_location: error_location_str }
     end
     case name
     when "modules"

lib/puppet/file_serving/fileset.rb

@@ -33,7 +33,7 @@ def initialize(path, options = {})
     else
       path = path.chomp(File::SEPARATOR) unless path == File::SEPARATOR
     end
-    raise ArgumentError.new(_("Fileset paths must be fully qualified: %{path}") % { path: path }) unless Puppet::Util.absolute_path?(path)
+    raise ArgumentError, _("Fileset paths must be fully qualified: %{path}") % { path: path } unless Puppet::Util.absolute_path?(path)
 
     @path = path
 
@@ -50,9 +50,9 @@ def initialize(path, options = {})
       initialize_from_hash(options)
     end
 
-    raise ArgumentError.new(_("Fileset paths must exist")) unless valid?(path)
+    raise ArgumentError, _("Fileset paths must exist") unless valid?(path)
     # TRANSLATORS "recurse" and "recurselimit" are parameter names and should not be translated
-    raise ArgumentError.new(_("Fileset recurse parameter must not be a number anymore, please use recurselimit")) if @recurse.is_a?(Integer)
+    raise ArgumentError, _("Fileset recurse parameter must not be a number anymore, please use recurselimit") if @recurse.is_a?(Integer)
   end
 
   # Return a list of all files in our fileset.  This is different from the
@@ -68,7 +68,7 @@ def files
     munged_max_files = max_files == '-1' ? -1 : max_files
 
     if munged_max_files > 0 && files.size > munged_max_files
-      raise Puppet::Error.new _("The directory '%{path}' contains %{entries} entries, which exceeds the limit of %{munged_max_files} specified by the max_files parameter for this resource. The limit may be increased, but be aware that large number of file resources can result in excessive resource consumption and degraded performance. Consider using an alternate method to manage large directory trees") % { path: path, entries: files.size, munged_max_files: munged_max_files }
+      raise Puppet::Error, _("The directory '%{path}' contains %{entries} entries, which exceeds the limit of %{munged_max_files} specified by the max_files parameter for this resource. The limit may be increased, but be aware that large number of file resources can result in excessive resource consumption and degraded performance. Consider using an alternate method to manage large directory trees") % { path: path, entries: files.size, munged_max_files: munged_max_files }
     elsif munged_max_files == 0 && files.size > soft_max_files
       Puppet.warning _("The directory '%{path}' contains %{entries} entries, which exceeds the default soft limit %{soft_max_files} and may cause excessive resource consumption and degraded performance. To remove this warning set a value for `max_files` parameter or consider using an alternate method to manage large directory trees") % { path: path, entries: files.size, soft_max_files: soft_max_files }
     end