Revert "(PUP-11320) Move ssh_authorized_key resources creation at the end"

This reverts commit 0343d57.

Author: joshcooper

acceptance/tests/resource/user/should_correctly_ensure_depending_resources.rb

@@ -66,6 +66,7 @@ module Puppet
     newproperty(:ensure, :parent => Puppet::Property::Ensure) do
       newvalue(:present, :event => :user_created) do
         provider.create
+        @resource.generate
       end
 
       newvalue(:absent, :event => :user_removed) do
@@ -692,8 +693,9 @@ def delimiter
       defaultto false
     end
 
-    def eval_generate
+    def generate
       if !self[:purge_ssh_keys].empty?
+        return [] if self[:ensure] == :present && !provider.exists? 
         if Puppet::Type.type(:ssh_authorized_key).nil?
           warning _("Ssh_authorized_key type is not available. Cannot purge SSH keys.")
         else

lib/puppet/type/user.rb

@@ -479,6 +479,21 @@ class container {
                          "Notify[goodbye]"))
     end
 
+    it "sets resources_failed_to_generate to true if resource#generate raises an exception" do
+      catalog = compile_to_ral(<<-MANIFEST)
+        user { 'foo':
+          ensure => present,
+        }
+      MANIFEST
+
+      allow(catalog.resource("User[foo]")).to receive(:generate).and_raise(RuntimeError)
+      relationship_graph = relationship_graph_for(catalog)
+      generator = Puppet::Transaction::AdditionalResourceGenerator.new(catalog, relationship_graph, prioritizer)
+      generator.generate_additional_resources(catalog.resource("User[foo]"))
+
+      expect(generator.resources_failed_to_generate).to be_truthy
+    end
+
     def relationships_after_generating(manifest, resource_to_generate)
       catalog = compile_to_ral(manifest)
       generate_resources_in(catalog, nil, resource_to_generate)