(maint) Add required feature to manual enable property of service

Author: luchihoratiu

lib/puppet/type/service.rb

@@ -41,6 +41,9 @@ module Puppet
     feature :delayed_startable, "The provider can set service to delayed start",
       :methods => [:delayed_start]
 
+    feature :manual_startable, "The provider can set service to manual start",
+      :methods => [:manual_start]
+
     feature :controllable, "The provider uses a control variable."
 
     feature :flaggable, "The provider can pass flags to the service."
@@ -70,7 +73,7 @@ module Puppet
         provider.disable
       end
 
-      newvalue(:manual, :event => :service_manual_start) do
+      newvalue(:manual, :event => :service_manual_start, :required_features => :manual_startable) do
         provider.manual_start
       end
 
@@ -92,13 +95,6 @@ def insync?(current)
         return provider.enabled_insync?(current) if provider.respond_to?(:enabled_insync?)
         super(current)
       end
-
-      validate do |value|
-        super(value)
-        if (value == :manual) && !Puppet::Util::Platform.windows?
-          raise Puppet::Error.new(_("Setting enable to %{value} is only supported on Microsoft Windows.") % { value: value.to_s} )
-        end
-      end
     end
 
     # Handle whether the service should actually be running right now.

spec/unit/type/service_spec.rb

@@ -84,12 +84,10 @@ def safely_load_service_type
         )
       end
 
-      it "should not support :manual as a value when not on Windows" do
-        allow(Puppet::Util::Platform).to receive(:windows?).and_return(false)
-
+      it "should not support :manual as a value" do
         expect { Puppet::Type.type(:service).new(:name => "yay", :enable => :manual) }.to raise_error(
-          Puppet::Error,
-          /Setting enable to manual is only supported on Microsoft Windows\./
+          Puppet::ResourceError,
+          /Provider .+ must have features 'manual_startable' to set 'enable' to 'manual'/
         )
       end