Layout/EmptyLinesAroundBlockBody

This commit enables the Rubocop Layout/EmptyLinesAroundBlockBody cop and
addresses all offenses.

Author: mhashizume

.rubocop_todo.yml

@@ -30,12 +30,6 @@ Layout/EmptyLineAfterGuardClause:
 Layout/EmptyLineAfterMagicComment:
   Enabled: false
 
-# This cop supports safe auto-correction (--auto-correct).
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: empty_lines, no_empty_lines
-Layout/EmptyLinesAroundBlockBody:
-  Enabled: false
-
 # This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: empty_lines, empty_lines_except_namespace, empty_lines_special, no_empty_lines, beginning_only, ending_only

lib/puppet/confine_collection.rb

@@ -42,7 +42,6 @@ def summary
       value = klass.summarize(list)
       next if (value.respond_to?(:length) and value.length == 0) or (value == 0)
       result[klass.name] = value
-
     end
     result
   end

lib/puppet/face/config.rb

@@ -136,7 +136,6 @@ def report_section_and_environment(section_name, environment_name)
     EOT
 
     when_invoked do |name, value, options|
-
       @default_section = false
       if options[:section] == DEFAULT_SECTION_MARKER
         options[:section] = DEFAULT_SECTION
@@ -219,7 +218,6 @@ def report_section_and_environment(section_name, environment_name)
     EOT
 
     when_invoked do |name, options|
-
       @default_section = false
       if options[:section] == DEFAULT_SECTION_MARKER
         options[:section] = DEFAULT_SECTION
@@ -230,7 +228,6 @@ def report_section_and_environment(section_name, environment_name)
       if Puppet::FileSystem.exist?(path)
         Puppet::FileSystem.open(path, nil, 'r+:UTF-8') do |file|
           Puppet::Settings::IniFile.update(file) do |config|
-
             # delete from both master section and server section
             if options[:section] == "master" || options[:section] == "server"
               master_setting_string = config.delete("master", name)

lib/puppet/face/epp.rb

@@ -333,7 +333,6 @@
 
       compiler = create_compiler(options)
       compiler.with_context_overrides('For rendering epp') do
-
         # Print to a buffer since the face needs to return the resulting string
         # and the face API is "all or nothing"
         #
@@ -562,5 +561,4 @@ def effective_template(file, env)
       nil
     end
   end
-
 end

lib/puppet/face/help.rb

@@ -239,5 +239,4 @@ def is_face_app?(appname)
   #  that you can't use the 'private' keyword inside of a Face definition.
   #  See #14205.
   #private :is_face_app?
-
 end

lib/puppet/face/node/clean.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 Puppet::Face.define(:node, '0.0.1') do
   action(:clean) do
-
     summary _("Clean up signed certs, cached facts, node objects, and reports for a node stored by the puppetmaster")
     arguments _("<host1> [<host2> ...]")
     description <<-'EOT'

lib/puppet/functions.rb

@@ -737,7 +737,6 @@ def method3x
       # When function is not an rvalue function, make sure it produces nil
       #
       the_class.class_eval do
-
         # Bypasses making the  call via the dispatcher to make sure errors
         # are reported exactly the same way as in 3x. The dispatcher is still needed as it is
         # used to support other features than calling.

lib/puppet/functions/call.rb

@@ -77,5 +77,4 @@ def call_impl_block(scope, function_name, *args, &block)
   def call_deferred(scope, deferred)
     Puppet::Pops::Evaluator::DeferredResolver.resolve(deferred, scope.compiler)
   end
-
 end

lib/puppet/functions/camelcase.rb

@@ -30,7 +30,6 @@
 # Would both result in `['AbcDef', 'BcdXyz']`
 #
 Puppet::Functions.create_function(:camelcase) do
-
   dispatch :on_numeric do
     param 'Numeric', :arg
   end

lib/puppet/functions/capitalize.rb

@@ -29,7 +29,6 @@
 # Would both result in `['Abc', 'Bcd']`
 #
 Puppet::Functions.create_function(:capitalize) do
-
   dispatch :on_numeric do
     param 'Numeric', :arg
   end