some more rubocop fixes

Author: buzzdeee

lib/puppet/provider/package/openbsd.rb

@@ -31,7 +31,7 @@ def self.instances
     begin
       packages = listcmd
       packages.each { |package, value|
-        if !package.empty?()
+        unless package.empty?()
           value[:provider] = name
           final << new(value)
         end
@@ -64,7 +64,7 @@ def self.listcmd
   def install
     cmd = []
 
-    full_name = get_full_name(action = "install")
+    full_name = get_full_name
 
     cmd << '-r'
     cmd << install_options
@@ -78,7 +78,7 @@ def install
     end
   end
 
-  def get_full_name(action = "install")
+  def get_full_name
     # In case of a real update (i.e., the package already exists) then
     # pkg_add(8) can handle the flavors. However, if we're actually
     # installing with 'latest', we do need to handle the flavors. This is
@@ -100,7 +100,6 @@ def get_full_name(action = "install")
     else
       "#{use_name}--#{use_branch}"
     end
-
   end
 
   def query
@@ -120,9 +119,9 @@ def uninstall_options
 
   def uninstall(purge = false)
     if purge
-      pkgdelete "-c", "-qq", uninstall_options.flatten.compact, get_full_name(action = "uninstall")
+      pkgdelete "-c", "-qq", uninstall_options.flatten.compact, get_full_name
     else
-      pkgdelete uninstall_options.flatten.compact, get_full_name(action = "uninstall")
+      pkgdelete uninstall_options.flatten.compact, get_full_name
     end
   end